<p dir="ltr"><br>
On Aug 4, 2015 7:51 AM, "Benjamin Kramer" <<a href="mailto:benny.kra@googlemail.com">benny.kra@googlemail.com</a>> wrote:<br>
><br>
> Author: d0k<br>
> Date: Tue Aug  4 09:46:06 2015<br>
> New Revision: 243987<br>
><br>
> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D243987-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=2a5apM8iJ7AlogEiO3DEwISgCnjqktYWggP8Ck_KDBg&s=OjglVRsubQeKW6JxmD-ZeU5YZ3f4pGmln4e4nABAn9g&e=">http://llvm.org/viewvc/llvm-project?rev=243987&view=rev</a><br>
> Log:<br>
> [Sema] Allocate SmallVector to the right size.<br>
><br>
> SmallVector::set_size does not reallocate the vector. Sadly I have no<br>
> idea how to test this. The vector never has more than one member in all<br>
> of the regression tests.</p>
<p dir="ltr">Could try adding an assert and self hosting to find a non-singular case? But yeah, I get that's probably not worth it.</p>
<p dir="ltr">Should we rename set_size something more intimidating/scary? That, or I'd love to remove it...</p>
<p dir="ltr">><br>
> Found by inspection.<br>
><br>
> Modified:<br>
>     cfe/trunk/lib/Sema/SemaTemplateInstantiateDecl.cpp<br>
><br>
> Modified: cfe/trunk/lib/Sema/SemaTemplateInstantiateDecl.cpp<br>
> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_lib_Sema_SemaTemplateInstantiateDecl.cpp-3Frev-3D243987-26r1-3D243986-26r2-3D243987-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=2a5apM8iJ7AlogEiO3DEwISgCnjqktYWggP8Ck_KDBg&s=nUE0DT5-lQv684gCWRWeDcdEgxpZl75N8VAbv2fjGLg&e=">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaTemplateInstantiateDecl.cpp?rev=243987&r1=243986&r2=243987&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/lib/Sema/SemaTemplateInstantiateDecl.cpp (original)<br>
> +++ cfe/trunk/lib/Sema/SemaTemplateInstantiateDecl.cpp Tue Aug  4 09:46:06 2015<br>
> @@ -1657,7 +1657,7 @@ TemplateDeclInstantiator::VisitCXXMethod<br>
>    SmallVector<TemplateParameterList *, 4> TempParamLists;<br>
>    unsigned NumTempParamLists = 0;<br>
>    if (isFriend && (NumTempParamLists = D->getNumTemplateParameterLists())) {<br>
> -    TempParamLists.set_size(NumTempParamLists);<br>
> +    TempParamLists.resize(NumTempParamLists);<br>
>      for (unsigned I = 0; I != NumTempParamLists; ++I) {<br>
>        TemplateParameterList *TempParams = D->getTemplateParameterList(I);<br>
>        TemplateParameterList *InstParams = SubstTemplateParams(TempParams);<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</p>