<div dir="ltr">Looks fine. I think these kinds of changes are simple enough that you can land them for post-commit review.<div><br></div><div>Forcing c++98 for the ms-extensions test is a bit strange since microsoft mode always enables c++11 (or even 14). Maybe we should just delete that test, it's probably from a while ago.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jul 30, 2015 at 4:14 PM, Li, Charles <span dir="ltr"><<a href="mailto:charles_li@playstation.sony.com" target="_blank">charles_li@playstation.sony.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Clang developers,<br>
<br>
<br>
We, here at Sony, have changed the default C++ language standard for PlayStation 4 to C++11 instead of C++98.<br>
When we ran the Clang Lit tests, 231 tests failed.<br>
We are currently going through and fixing each test to allow for flexible compatibility with current and future C++ standards.<br>
<br>
Attached is the first fix. This simple fix made the C++ standard dialect explicit on 5 five test file.<br>
Here are a brief description for each change:<br>
<br>
test/Lexer/cxx0x_keyword_as_cxx98.cpp<br>
This test checks for diagnostics on C++11 keywords when compiling on older dialects.<br>
For this test, I have made the C++ dialects explicit to C++98 and C++03.<br>
<br>
test/Lexer/has_feature_cxx0x.cpp<br>
This test checks for supported language features when compiling at various dialects.<br>
For this test, I have made the C++ dialects explicit to C++98 and C++03.<br>
<br>
test/Lexer/ms-extensions.cpp<br>
This test checks for the Warning diagnostic on user-defined literal on older dialects.<br>
For this test, I have made the C++ dialects explicit to C++98 and C++03.<br>
<br>
test/Preprocessor/macro-reserved.cpp<br>
This test checks for reserved keywords prior to C++11.<br>
For this test, I have made the C++ dialects explicit to C++98 and C++03.<br>
<br>
test/Preprocessor/macro-reserved-cxx11.cpp<br>
This test checks for reserved keywords on C++11.<br>
Since C++11 and C++14 share the same keywords, I have added a RUN line for C++14.<br>
Please let me know if you feel a separate test file should be created for C++14.<br>
<br>
<br>
All of the above 5 tests are relatively straight forward tests checking for C++ dialect specific behavior.<br>
I personally feel adding "-std=" flags to the RUN line of each of the above test will suffice.<br>
While there are other tests that can be fixed with such a straight forward fix,<br>
many of the other tests will require more nuanced modifications to the test code in order to<br>
accommodate for finer differences in the C++ dialects.<br>
I hope to expand the scope of the discussion as this work progresses.<br>
<br>
The final goal of this project, to be submitted over several patches, is to, without breaking the<br>
current state, arrive at a situation where the clang lit tests can pass, with no further<br>
changes to tests, if the default language dialect is changed from C++98 to C++11.<br>
<br>
This will make the task of changing the default dialect a trivial step, whenever it happens.<br>
Meanwhile, it will help any current clang users who are setting the default to C++11, as we do.<br>
<br>
<br>
Sincerely,<br>
Charles Li<br>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>