<div dir="ltr">Hi Kristof,<div><br></div><div>As this causes a crash and is a trivial fix, would it be worth getting it merged to 3.7?</div><div><br></div><div>Cheers,</div><div><br></div><div>James</div><br><div class="gmail_quote"><div dir="ltr">On Tue, 28 Jul 2015 at 15:31 Kristof Beyls <<a href="mailto:kristof.beyls@arm.com">kristof.beyls@arm.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: kbeyls<br>
Date: Tue Jul 28 09:23:47 2015<br>
New Revision: 243417<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D243417-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=s8BTSM2CCpZtP0JaST2pXLmzEAcZzIagT6C-pkKe08A&s=pW1Vly_YSSHsClxuKKvMvK2v5zyuG1N6nD_VFFyZPeQ&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=243417&view=rev</a><br>
Log:<br>
RegParmMax must be 0 for AArch64, as the regparm function attribute is not supported on AArch64.<br>
<br>
<br>
Modified:<br>
    cfe/trunk/lib/Basic/Targets.cpp<br>
    cfe/trunk/test/CodeGen/le32-regparm.c<br>
<br>
Modified: cfe/trunk/lib/Basic/Targets.cpp<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_lib_Basic_Targets.cpp-3Frev-3D243417-26r1-3D243416-26r2-3D243417-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=s8BTSM2CCpZtP0JaST2pXLmzEAcZzIagT6C-pkKe08A&s=TMClZbqCTEz2bl19qGjQv0-RwQ1Cv584hg8vU8-aTKI&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=243417&r1=243416&r2=243417&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Basic/Targets.cpp (original)<br>
+++ cfe/trunk/lib/Basic/Targets.cpp Tue Jul 28 09:23:47 2015<br>
@@ -5082,7 +5082,6 @@ public:<br>
<br>
     LongWidth = LongAlign = PointerWidth = PointerAlign = 64;<br>
     MaxVectorAlign = 128;<br>
-    RegParmMax = 8;<br>
     MaxAtomicInlineWidth = 128;<br>
     MaxAtomicPromoteWidth = 128;<br>
<br>
<br>
Modified: cfe/trunk/test/CodeGen/le32-regparm.c<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_test_CodeGen_le32-2Dregparm.c-3Frev-3D243417-26r1-3D243416-26r2-3D243417-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=s8BTSM2CCpZtP0JaST2pXLmzEAcZzIagT6C-pkKe08A&s=svPGby3xoCxqpiTvbQhZovP5PHi_zmb48WgR6B9mYpE&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/le32-regparm.c?rev=243417&r1=243416&r2=243417&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/CodeGen/le32-regparm.c (original)<br>
+++ cfe/trunk/test/CodeGen/le32-regparm.c Tue Jul 28 09:23:47 2015<br>
@@ -1,4 +1,5 @@<br>
 // RUN: %clang_cc1 -triple le32-unknown-nacl %s -fsyntax-only -verify<br>
+// RUN: %clang_cc1 -triple aarch64 %s -fsyntax-only -verify<br>
<br>
 void __attribute__((regparm(2))) fc_f1(int i, int j, int k) {} // expected-error{{'regparm' is not valid on this platform}}<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div></div>