<div dir="rtl"><div dir="ltr">+cfe-commits</div><div dir="ltr"><br></div><div dir="ltr">This is a very large Solaris special case in ScanLibDirForGCCTriple which shares almost no code with the function.</div><div dir="ltr">How about splitting it out to a helper function or making ScanLibDirForGCCTriple virtual and overriding on Solaris?</div><div dir="ltr"><br></div><div dir="ltr"><br></div><div dir="ltr"><br></div><div dir="ltr"><br></div><div dir="ltr"><br></div></div><div class="gmail_extra"><br><div class="gmail_quote"><div dir="ltr">2015-07-28 13:17 GMT+03:00 Xan López <span dir="ltr"><<a href="mailto:xan@igalia.com" target="_blank">xan@igalia.com</a>></span>:</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
the lookup code for all crt (and ld.so) files in Solaris is hardcoded,<br>
it will only work in a ~2012-ish Solaris/x86 machine with a single GCC<br>
version.<br>
<br>
This patch refactors the code to use the GCC installation detector<br>
(modified so that it works in Solaris), and uses<br>
ToolChain::GetFilePath everywhere once it works.<br>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>