<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Jul 26, 2015 at 11:27 PM, Sean Silva <span dir="ltr"><<a href="mailto:chisophugis@gmail.com" target="_blank">chisophugis@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Sun, Jul 26, 2015 at 6:06 PM, David Majnemer <span dir="ltr"><<a href="mailto:david.majnemer@gmail.com" target="_blank">david.majnemer@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br><br>On Sunday, July 26, 2015, Sean Silva <<a href="mailto:chisophugis@gmail.com" target="_blank">chisophugis@gmail.com</a>> wrote:<span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Jul 26, 2015 at 4:17 PM, David Majnemer <span dir="ltr"><<a>david.majnemer@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: majnemer<br>
Date: Sun Jul 26 18:17:29 2015<br>
New Revision: 243255<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D243255-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=auUYUgD_ppTyVbTEusYzfCbyiE4fa5KjFHkvRL411d4&s=OugINxqrJ6bsH6obWoWzmg1qqPIm_Qzq07Tc76f95N8&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=243255&view=rev</a><br>
Log:<br>
[Targets] Define _M_AMD64 and _M_X64 to a more appropriate value<br>
<br>
We used to define them to 1, we should have defined them to 100.<br></blockquote><div><br></div><div>Why?</div><div></div></div></div></div></blockquote><div><br></div></span><div>Because that's what they do and I see no particular reason to be gratuitously different.</div><span><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>Do you have a link or something that you could cite in the code here?</div><div></div></div></div></div></blockquote><div><br></div></span><div>No, it was found by inspection.</div></blockquote><div><br></div></span><div>Could you maybe add a comment "// MSVC seems to set them to these values. Tested with MSVC <version>."</div><div>Or something like that?</div></div></div></div></blockquote><div><br></div><div>I don't think comments like "MSVC seems to set them to these values" are particularly enlightening. Behavior compatible with MSVC is the norm, not the exception. Our comments generally point out cases where our compatibility is subpar, stuff like _MSC_BUILD always being set to 1 or when there is an air of mystery behind some flag bits in an RTTI data structure. I think the reader should assume that if clang unconditionally defines a macro to some value, we did so because it was the compatible thing to do.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="HOEnZb"><font color="#888888"><div><br></div><div>-- Sean Silva</div></font></span><div><div class="h5"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> </div></div></div></div></blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div>-- Sean Silva</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>
<br>
Modified:<br>
cfe/trunk/lib/Basic/Targets.cpp<br>
cfe/trunk/test/Preprocessor/predefined-macros.c<br>
<br>
Modified: cfe/trunk/lib/Basic/Targets.cpp<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_lib_Basic_Targets.cpp-3Frev-3D243255-26r1-3D243254-26r2-3D243255-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=auUYUgD_ppTyVbTEusYzfCbyiE4fa5KjFHkvRL411d4&s=o13BM3LE76_FM5Mf5bBWt8upbZNf8elBhjEJRLOCpBo&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=243255&r1=243254&r2=243255&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Basic/Targets.cpp (original)<br>
+++ cfe/trunk/lib/Basic/Targets.cpp Sun Jul 26 18:17:29 2015<br>
@@ -4000,8 +4000,8 @@ public:<br>
MacroBuilder &Builder) const override {<br>
WindowsX86_64TargetInfo::getTargetDefines(Opts, Builder);<br>
WindowsX86_64TargetInfo::getVisualStudioDefines(Opts, Builder);<br>
- Builder.defineMacro("_M_X64");<br>
- Builder.defineMacro("_M_AMD64");<br>
+ Builder.defineMacro("_M_X64", "100");<br>
+ Builder.defineMacro("_M_AMD64", "100");<br>
}<br>
};<br>
<br>
<br>
Modified: cfe/trunk/test/Preprocessor/predefined-macros.c<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_test_Preprocessor_predefined-2Dmacros.c-3Frev-3D243255-26r1-3D243254-26r2-3D243255-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=auUYUgD_ppTyVbTEusYzfCbyiE4fa5KjFHkvRL411d4&s=qcvP03Cw1XU9Lx6LaBg1zKkTo53ORSNsLDiHSjs8dsA&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Preprocessor/predefined-macros.c?rev=243255&r1=243254&r2=243255&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/Preprocessor/predefined-macros.c (original)<br>
+++ cfe/trunk/test/Preprocessor/predefined-macros.c Sun Jul 26 18:17:29 2015<br>
@@ -18,8 +18,8 @@<br>
// CHECK-MS64: #define _INTEGRAL_MAX_BITS 64<br>
// CHECK-MS64: #define _MSC_EXTENSIONS 1<br>
// CHECK-MS64: #define _MSC_VER 1300<br>
-// CHECK-MS64: #define _M_AMD64 1<br>
-// CHECK-MS64: #define _M_X64 1<br>
+// CHECK-MS64: #define _M_AMD64 100<br>
+// CHECK-MS64: #define _M_X64 100<br>
// CHECK-MS64: #define _WIN64 1<br>
// CHECK-MS64-NOT: #define __STRICT_ANSI__<br>
// CHECK-MS64-NOT: GCC<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
</div></div><span><a>cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</span></blockquote></div><br></div></div>
</blockquote>
</blockquote></div></div></div><br></div></div>
</blockquote></div><br></div></div>