<br><br>On Sunday, July 26, 2015, Sean Silva <<a href="mailto:chisophugis@gmail.com">chisophugis@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Jul 26, 2015 at 4:17 PM, David Majnemer <span dir="ltr"><<a href="javascript:_e(%7B%7D,'cvml','david.majnemer@gmail.com');" target="_blank">david.majnemer@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: majnemer<br>
Date: Sun Jul 26 18:17:29 2015<br>
New Revision: 243255<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D243255-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=fUQJqhgS44u5dPvE89Zikh-sZTaploKrnLSYvEhezks&s=4_hrPh5cyAfXD9K3zz_t9rpNPsjbTn6zQRMMoGLK5t4&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=243255&view=rev</a><br>
Log:<br>
[Targets] Define _M_AMD64 and _M_X64 to a more appropriate value<br>
<br>
We used to define them to 1, we should have defined them to 100.<br></blockquote><div><br></div><div>Why?</div><div></div></div></div></div></blockquote><div><br></div><div>Because that's what they do and I see no particular reason to be gratuitously different.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>Do you have a link or something that you could cite in the code here?</div><div></div></div></div></div></blockquote><div><br></div><div>No, it was found by inspection.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> </div></div></div></div></blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div>-- Sean Silva</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
    cfe/trunk/lib/Basic/Targets.cpp<br>
    cfe/trunk/test/Preprocessor/predefined-macros.c<br>
<br>
Modified: cfe/trunk/lib/Basic/Targets.cpp<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_lib_Basic_Targets.cpp-3Frev-3D243255-26r1-3D243254-26r2-3D243255-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=fUQJqhgS44u5dPvE89Zikh-sZTaploKrnLSYvEhezks&s=AEKSWc7J5GnhUGewAMw13AGiTRWjdhYVNeZyxAjgfnc&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=243255&r1=243254&r2=243255&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Basic/Targets.cpp (original)<br>
+++ cfe/trunk/lib/Basic/Targets.cpp Sun Jul 26 18:17:29 2015<br>
@@ -4000,8 +4000,8 @@ public:<br>
                         MacroBuilder &Builder) const override {<br>
     WindowsX86_64TargetInfo::getTargetDefines(Opts, Builder);<br>
     WindowsX86_64TargetInfo::getVisualStudioDefines(Opts, Builder);<br>
-    Builder.defineMacro("_M_X64");<br>
-    Builder.defineMacro("_M_AMD64");<br>
+    Builder.defineMacro("_M_X64", "100");<br>
+    Builder.defineMacro("_M_AMD64", "100");<br>
   }<br>
 };<br>
<br>
<br>
Modified: cfe/trunk/test/Preprocessor/predefined-macros.c<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_test_Preprocessor_predefined-2Dmacros.c-3Frev-3D243255-26r1-3D243254-26r2-3D243255-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=fUQJqhgS44u5dPvE89Zikh-sZTaploKrnLSYvEhezks&s=eqXjqFxLo753NFyiVb0RJ_XbGgx0sNcxTjacmEpLcSw&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Preprocessor/predefined-macros.c?rev=243255&r1=243254&r2=243255&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/Preprocessor/predefined-macros.c (original)<br>
+++ cfe/trunk/test/Preprocessor/predefined-macros.c Sun Jul 26 18:17:29 2015<br>
@@ -18,8 +18,8 @@<br>
 // CHECK-MS64: #define _INTEGRAL_MAX_BITS 64<br>
 // CHECK-MS64: #define _MSC_EXTENSIONS 1<br>
 // CHECK-MS64: #define _MSC_VER 1300<br>
-// CHECK-MS64: #define _M_AMD64 1<br>
-// CHECK-MS64: #define _M_X64 1<br>
+// CHECK-MS64: #define _M_AMD64 100<br>
+// CHECK-MS64: #define _M_X64 100<br>
 // CHECK-MS64: #define _WIN64 1<br>
 // CHECK-MS64-NOT: #define __STRICT_ANSI__<br>
 // CHECK-MS64-NOT: GCC<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="javascript:_e(%7B%7D,'cvml','cfe-commits@cs.uiuc.edu');" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>
</blockquote>