<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jul 17, 2015, at 5:00 PM, Richard Smith <<a href="mailto:richard@metafoo.co.uk" class="">richard@metafoo.co.uk</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote">On Fri, Jul 17, 2015 at 3:43 PM, David Majnemer <span dir="ltr" class=""><<a href="mailto:david.majnemer@gmail.com" target="_blank" class="">david.majnemer@gmail.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr" class=""><br class=""><div class="gmail_extra"><br class=""><div class="gmail_quote"><span class="">On Fri, Jul 17, 2015 at 3:13 PM, Richard Smith <span dir="ltr" class=""><<a href="mailto:richard@metafoo.co.uk" target="_blank" class="">richard@metafoo.co.uk</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr" class="">It seems to me that we should be basing the check on the TargetCXXABI rather than whether the target is Windows.</div></blockquote><div class=""><br class=""></div></span><div class="">That's why I suggested to use llvm::Triple::isKnownWindowsMSVCEnvironment, it's what we use to set the CXX ABI: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_lib_Basic_TargetInfo.cpp-3Frevision-3D242198-26view-3Dmarkup-23l87&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=G3MVPiIuh9Zu9HyzhnePJCf25I6f-1MwpsQj4utGWto&s=KEA3UO4jwzX7cHyKdUCfHMcIZdkf_BpNhd5YnO58M_8&e=" target="_blank" class="">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/TargetInfo.cpp?revision=242198&view=markup#l87</a></div></div></div></div></blockquote><div class=""><br class=""></div><div class="">That's only the default; targets are permitted to override it, and many of them do so. <span style="white-space: pre-wrap;" class="">ItaniumWindowsARMleTargetInfo sets a non-MS C++ ABI, for instance.</span></div></div></div></div></div></blockquote><br class=""></div><div>Here’s a new patch that checks TargetCXXABI.</div></body></html>