<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Jul 15, 2015 at 4:52 PM, Nathan Wilson <span dir="ltr"><<a href="mailto:nwilson20@gmail.com" target="_blank">nwilson20@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">nwilson added inline comments.<br>
<span class=""><br>
================<br>
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1965-1966<br>
@@ +1964,4 @@<br>
</span>+  "concept declarations may only appear in namespace scope">;<br>
+def err_function_concept_not_defined : Error<<br>
<span class="">+  "function concept declaration must be a definition">;<br>
+<br>
----------------<br>
</span><span class="">rsmith wrote:<br>
> Does this not also apply to variable concepts? For instance<br>
><br>
>   template<typename T> extern concept bool b;<br></span></blockquote><div>A variable concept requires an initializer, not just a definition.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="">
</span>Could we create a separate diagnostic for that?  i.e.:<br>
<br>
def err_variable_concept_not_intialized : Error<<br>
  "variable concept declaration requires initialization">;<br></blockquote><div>My preferred message text is:<br><br>function concept declaration must be a definition<br>variable concept declaration must have an initializer<br><br></div><div>I do not see an advantage to using the same message identifier for the two. Indeed, doing that might cause difficulties for message translation efforts.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D11027&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=kWrsi9Wr8WF98sIaYtG4YgDV4gmJsHoTrKo4CvXCl34&s=4fOC_dlc1kPZDf33npq3TW-j8Qa-Cq8gtd7xTcN-fAs&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/D11027</a><br>
<br>
<br>
<br>
</blockquote></div><br></div></div>