<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Mon, Jul 6, 2015 at 4:55 PM Aaron Ballman <<a href="mailto:aaron@aaronballman.com">aaron@aaronballman.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Mon, Jul 6, 2015 at 7:51 PM, Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>> wrote:<br>
> Author: echristo<br>
> Date: Mon Jul  6 18:51:56 2015<br>
> New Revision: 241524<br>
><br>
> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D241524-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=tH6G14SslMf3mjYt52T57nnCUH9pWwD6LyjltY9KDUo&s=6AByNiskEDoGa47J0tQ_YclUYdiYPpGmD5dR8RRMx2M&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=241524&view=rev</a><br>
> Log:<br>
> Add some basic documentation for the __attribute__((target(""))) support.<br>
><br>
> Describes the general syntax of how it's used with the unfortunate<br>
> usage of "subtarget features" and some examples from the x86 port<br>
> to help users.<br>
><br>
> Modified:<br>
>     cfe/trunk/include/clang/Basic/AttrDocs.td<br>
<br>
Did you forget to change the Undocument in Attr.td for the TargetAttr object?<br></blockquote><div><br></div><div>Why yes, yes I did.</div><div><br></div><div><div>dzur:~/sources/llvm/tools/clang> git svn dcommit </div><div>Committing to <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__llvm.org_svn_llvm-2Dproject_cfe_trunk&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=tH6G14SslMf3mjYt52T57nnCUH9pWwD6LyjltY9KDUo&s=DAWpvmJp5zXgFi7Wo7Ku8LPxiVKQEXWcQSx4iKlhhOs&e=">https://llvm.org/svn/llvm-project/cfe/trunk</a> ...</div><div><span class="Apple-tab-span" style="white-space:pre">       </span>M<span class="Apple-tab-span" style="white-space:pre">   </span>include/clang/Basic/Attr.td</div><div>Committed r241529</div></div><div><br></div><div>Thanks!</div><div><br></div><div>-eric</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
~Aaron<br>
<br>
><br>
> Modified: cfe/trunk/include/clang/Basic/AttrDocs.td<br>
> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_include_clang_Basic_AttrDocs.td-3Frev-3D241524-26r1-3D241523-26r2-3D241524-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=tH6G14SslMf3mjYt52T57nnCUH9pWwD6LyjltY9KDUo&s=91GIjnqwl2-m5rymloOluZAciD_Z3dt1TdgHgJ5sNgU&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/AttrDocs.td?rev=241524&r1=241523&r2=241524&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/include/clang/Basic/AttrDocs.td (original)<br>
> +++ cfe/trunk/include/clang/Basic/AttrDocs.td Mon Jul  6 18:51:56 2015<br>
> @@ -678,6 +678,25 @@ The semantics are as follows:<br>
>    }];<br>
>  }<br>
><br>
> +def TargetDocs : Documentation {<br>
> +  let Category = DocCatFunction;<br>
> +  let Content = [{<br>
> +Clang supports the GNU style ``__attribute__((target("OPTIONS")))`` attribute.<br>
> +This attribute may be attached to a function definition and instructs<br>
> +the backend to use different code generation options than were passed on the<br>
> +command line.<br>
> +<br>
> +The current set of options correspond to the existing "subtarget features" for<br>
> +the target with or without a "-mno-" in front corresponding to the absence<br>
> +of the feature, as well as ``arch="CPU"`` which will change the default "CPU"<br>
> +for the function.<br>
> +<br>
> +Example "subtarget features" from the x86 backend include: "mmx", "sse", "sse4.2",<br>
> +"avx", "xop" and largely correspond to the machine specific options handled by<br>
> +the front end.<br>
> +}];<br>
> +}<br>
> +<br>
>  def DocCatAMDGPURegisterAttributes :<br>
>    DocumentationCategory<"AMD GPU Register Attributes"> {<br>
>    let Content = [{<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div></div>