<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Mon, Jul 6, 2015 at 4:57 PM Aaron Ballman <<a href="mailto:aaron@aaronballman.com">aaron@aaronballman.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Mon, Jul 6, 2015 at 7:52 PM, Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>> wrote:<br>
> Author: echristo<br>
> Date: Mon Jul  6 18:52:01 2015<br>
> New Revision: 241526<br>
><br>
> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D241526-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=3JzdqWQFPzWopNWEug1sErxU1h5O08hFgC8klEAmDJc&s=LuKj6FFsvSJ0dP3FjBzII0Pp0Ucjh5cg40UavPubGN0&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=241526&view=rev</a><br>
> Log:<br>
> Update target attribute support for post-commit feedback.<br>
><br>
> Use const auto rather than duplicating the type name and fix the<br>
> error message when the attribute is applied to an incorrect entity.<br>
<br>
Thank you for this (one comment below)!<br>
<br>
><br>
> Modified:<br>
>     cfe/trunk/include/clang/Basic/Attr.td<br>
>     cfe/trunk/lib/CodeGen/CGCall.cpp<br>
><br>
> Modified: cfe/trunk/include/clang/Basic/Attr.td<br>
> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_include_clang_Basic_Attr.td-3Frev-3D241526-26r1-3D241525-26r2-3D241526-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=3JzdqWQFPzWopNWEug1sErxU1h5O08hFgC8klEAmDJc&s=5-dhr67eNFfq28d-goN8QuGUxfjXtQMqpTAEgdQt_pY&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/Attr.td?rev=241526&r1=241525&r2=241526&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/include/clang/Basic/Attr.td (original)<br>
> +++ cfe/trunk/include/clang/Basic/Attr.td Mon Jul  6 18:52:01 2015<br>
> @@ -1277,7 +1277,7 @@ def Target : InheritableAttr {<br>
>    let Spellings = [GCC<"target">];<br>
>    let Args = [StringArgument<"features">];<br>
>    let Subjects =<br>
> -      SubjectList<[Function], ErrorDiag, "ExpectedFunctionMethodOrClass">;<br>
> +      SubjectList<[Function], ErrorDiag, "ExpectedFunction">;<br>
<br>
You can actually elide the ExpectedFunction part as well. The tablegen<br>
smarts handle the easy cases for you.<br>
<br></blockquote><div><br></div><div>Hey, cool, thanks :)</div><div><br></div><div>Done thusly:</div><div><br></div><div><div>dzur:~/sources/llvm/tools/clang> git svn dcommit </div><div>Committing to <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__llvm.org_svn_llvm-2Dproject_cfe_trunk&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=3JzdqWQFPzWopNWEug1sErxU1h5O08hFgC8klEAmDJc&s=5ffHeWbqVZe9C0DfGx8Hi24D9RPtYJuJpvarr52hBa0&e=">https://llvm.org/svn/llvm-project/cfe/trunk</a> ...</div><div><span class="Apple-tab-span" style="white-space:pre">       </span>M<span class="Apple-tab-span" style="white-space:pre">   </span>include/clang/Basic/Attr.td</div><div>Committed r241529</div></div><div><br></div><div><br></div><div>-eric</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
~Aaron<br>
<br>
>    let Documentation = [Undocumented];<br>
>  }<br>
><br>
><br>
> Modified: cfe/trunk/lib/CodeGen/CGCall.cpp<br>
> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_lib_CodeGen_CGCall.cpp-3Frev-3D241526-26r1-3D241525-26r2-3D241526-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=3JzdqWQFPzWopNWEug1sErxU1h5O08hFgC8klEAmDJc&s=PFf6hfwDYVVX0rGGTZNp2Du_OaoMm_PZU_QPWotj79U&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGCall.cpp?rev=241526&r1=241525&r2=241526&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/lib/CodeGen/CGCall.cpp (original)<br>
> +++ cfe/trunk/lib/CodeGen/CGCall.cpp Mon Jul  6 18:52:01 2015<br>
> @@ -1506,7 +1506,7 @@ void CodeGenModule::ConstructAttributeLi<br>
><br>
>      const FunctionDecl *FD = dyn_cast_or_null<FunctionDecl>(TargetDecl);<br>
>      if (FD) {<br>
> -      if (const TargetAttr *TD = FD->getAttr<TargetAttr>()) {<br>
> +      if (const auto *TD = FD->getAttr<TargetAttr>()) {<br>
>          StringRef FeaturesStr = TD->getFeatures();<br>
>          SmallVector<StringRef, 1> AttrFeatures;<br>
>          FeaturesStr.split(AttrFeatures, ",");<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div></div>