<div dir="ltr">Do you need to resolve the Context in the retained types iteration? If it's a lexical block it shouldn't ever be a scope ref, I think? Not sure.<br><br>(mostly I'm just concerned aobut the inconsistency between that case and the global variable case above)<br><br>In DwarfCompileUnit - perhaps:<br><br>  auto LocalDeclNodeRangeForScope = DD->findLocalDeclNodesForScope(DS);<br><br>could be changed to:<br><br>  iterator_range<LocalDeclMap::const_iterator> LocalDeclNodeRangeForScope;<br>  if (!includeMinimalInlineScopes())<br>    LocalDeclNodeRangeForScope = DD->findLocalDeclNodesForScope(DS);<br><br>Then you can drop the includeMinimalInlineScopes() condition from the following if and the if around the for loop furtehr down, I think? (with the caveat that I'm not sure if iterator_range is guaranteed (or can be guaranteed) to produce an empty range - not sure if two default constructed iterators are guaranteed/meant to be equal to each other - could check the spec, etc)<br><br>- David</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 29, 2015 at 12:18 AM, Amjad Aboud <span dir="ltr"><<a href="mailto:amjad.aboud@intel.com" target="_blank">amjad.aboud@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Updated the LLVM version to 240902 (close to top of trunk preparing for commit).<br>
<span class=""><br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D9760&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=-hFvwUaZTVzRqRenpZmmtUtY1hsHAORU-hUN0j0izMQ&s=BPE1CQ2WVs1ch1S-DfBdsF2uSqsN6EYtnaQxpYYSWv8&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/D9760</a><br>
<br>
Files:<br>
  lib/CodeGen/CGDebugInfo.cpp<br>
  lib/CodeGen/CGDebugInfo.h<br>
  lib/CodeGen/CGDecl.cpp<br>
  test/CodeGenCXX/debug-info-lb-class.cpp<br>
  test/CodeGenCXX/debug-info-lb-static.cpp<br>
</span>  test/CodeGenCXX/debug-info-lb-static2.cpp<br>
<div class="HOEnZb"><div class="h5">  test/CodeGenCXX/debug-info-lb-typedef.cpp<br>
<br>
EMAIL PREFERENCES<br>
  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=-hFvwUaZTVzRqRenpZmmtUtY1hsHAORU-hUN0j0izMQ&s=rFORqQU3w8Dzqgxg_xeRmeRGB2NQurF8zTUTLi0TIEI&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
</div></div></blockquote></div><br></div>