<div dir="ltr">Sure thing - committed in r240971</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 29, 2015 at 3:50 AM, Ying Yi <span dir="ltr"><<a href="mailto:maggieyi666@gmail.com" target="_blank">maggieyi666@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">
<p class="MsoNormal">Hello David,</p><p class="MsoNormal"><br></p>
<p class="MsoNormal">Many thanks for your comments. When I modified the regression
tests to add the calling conventions, I considered using “{{\w*}}” as well.
However, I found some tests with calling conventions that used {{.*}}.
Therefore, I have used {{.*}} to make the tests consistent. I hope this is ok.</p><p class="MsoNormal"><br></p>
<p class="MsoNormal">I don’t have commit
access at the moment since this patch is my first patch to cfe-commits. As
mentioned in <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_docs_DeveloperPolicy.html-23making-2Dand-2Dsubmitting-2Da-2Dpatch&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=trUBSA1BRId6-pL9csQh9q0SJfTz1PCKjCotXhSSppc&s=QXfcxOZjo68rvsCRHckvwAiNPrTbkG-AmtANA0n2mB0&e=" target="_blank">http://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch</a>,
the commit access is granted to contributors with a track record of submitting
high quality patches. <br></p><p class="MsoNormal"><br></p>
<p class="MsoNormal">Could you please help me by committing this patch or advise
what do I need to do in order to commit this change?</p>
<p class="MsoNormal"><br></p><p class="MsoNormal">Many thanks,</p>
<p class="MsoNormal"></p><p class="MsoNormal">Ying Yi<br></p>
<br><div class="gmail_extra"><div><div class="h5"><br><div class="gmail_quote">On Fri, Jun 26, 2015 at 5:24 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Looks good to me, please commit.<br><br>(optionally, if you could put a space in the regex, that might not hurt:<br><br> define {{.* }}void<br><br>maybe even:<br><br> define {{\w* }}void<br><br>So it only accepts one token and doesn't accidentally eat more things. Probably not terribly important and maybe what you have is the better readability/accuracy tradeoff anyway.)</div><div class="gmail_extra"><br><div class="gmail_quote"><div><div>On Fri, Jun 26, 2015 at 2:16 AM, Maggie Yi <span dir="ltr"><<a href="mailto:maggieyi666@gmail.com" target="_blank">maggieyi666@gmail.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div><div dir="ltr">
<p class="MsoNormal"><span style="font-size:10pt;line-height:115%;color:black">Dear All,<br>
<span> </span><br>
I would like to </span><span style="font-size:10pt;line-height:115%">propose a patch
for <span style="color:black">clang regression tests that will fail on targets
that set specific calling conventions.<br>
<br>For example, in Clang :: CodeGen/builtinshufflevector2.c:<br>
<br> Expected IR:<br>
<br>
"define void @clang_shufflevector_v_v"<br>
<br>
IR generated with a default triple of armv7a_pc_linux:<br>
<br>
"define arm_aapcs void @clang_shufflevector_v_v"<br>
<br> The test could be changed to expect "define{{.*}} void @clang_shufflevector_v_v".<br>
<span> </span><br>
For ARM target with default triple armv7a_pc_linux, around 81 clang
regression tests failed due to the same reason. <br></span></span></p><p class="MsoNormal"><span style="font-size:10pt;line-height:115%"><span style="color:black">It includes CodeGen,
CodeGenCXX, CodeGenObjC, CodeGenObjCXX, CodeGenOpenCL, Modules, OpenMP, <br>
PCH, Profile and Sema tests.</span> Please see attached the patch file for the
details.<span style="color:black"> <br>
<br>
</span>Please let me know if this is an acceptable change.</span></p>
<p class="MsoNormal"><span style="font-size:10pt;line-height:115%;color:black"><span> </span><br>
Kind Regards,</span></p><p class="MsoNormal"><span style="font-size:10pt;line-height:115%;color:black"><br></span></p>
<span style="font-size:10pt;line-height:115%;font-family:"Calibri","sans-serif";color:black">Ying</span></div>
<br></div></div>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>
</blockquote></div><br><br clear="all"><br></div></div><span class="HOEnZb"><font color="#888888">-- <br><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><font size="2"><span style="font-family:arial,helvetica,sans-serif">Ying Yi</span><span style="font-family:arial,helvetica,sans-serif"><br>SN Systems Ltd - Sony Computer Entertainment Group.</span><span style="font-family:arial,helvetica,sans-serif"></span></font><br></div></div></div></div></div></div>
</font></span></div></div>
</blockquote></div><br></div>