<div dir="ltr">can/should there be any test coverage for this? (I suppose there's probably not any test coverage that would catch added fields without using UB to scramble the object's bits... )</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jun 26, 2015 at 4:40 PM, Birunthan Mohanathas <span dir="ltr"><<a href="mailto:birunthan@mohanathas.com" target="_blank">birunthan@mohanathas.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi djasper,<br>
<br>
Depends on D10784.<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10785&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=RWUOx_h_jYwGryHCjPEjRNA6N30U3DXOuIC5pLwMk20&s=a9SLm-TbGJ7eWqBdCtjha0qdpSWpwQB-yiKRxTdu4-8&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/D10785</a><br>
<br>
Files:<br>
  include/clang/Format/Format.h<br>
<br>
Index: include/clang/Format/Format.h<br>
===================================================================<br>
--- include/clang/Format/Format.h<br>
+++ include/clang/Format/Format.h<br>
@@ -427,12 +427,15 @@<br>
   bool operator==(const FormatStyle &R) const {<br>
     return AccessModifierOffset == R.AccessModifierOffset &&<br>
            AlignAfterOpenBracket == R.AlignAfterOpenBracket &&<br>
+           AlignConsecutiveAssignments == R.AlignConsecutiveAssignments &&<br>
            AlignEscapedNewlinesLeft == R.AlignEscapedNewlinesLeft &&<br>
            AlignOperands == R.AlignOperands &&<br>
            AlignTrailingComments == R.AlignTrailingComments &&<br>
            AllowAllParametersOfDeclarationOnNextLine ==<br>
                R.AllowAllParametersOfDeclarationOnNextLine &&<br>
            AllowShortBlocksOnASingleLine == R.AllowShortBlocksOnASingleLine &&<br>
+           AllowShortCaseLabelsOnASingleLine ==<br>
+               R.AllowShortCaseLabelsOnASingleLine &&<br>
            AllowShortFunctionsOnASingleLine ==<br>
                R.AllowShortFunctionsOnASingleLine &&<br>
            AllowShortIfStatementsOnASingleLine ==<br>
@@ -460,6 +463,7 @@<br>
            ContinuationIndentWidth == R.ContinuationIndentWidth &&<br>
            Cpp11BracedListStyle == R.Cpp11BracedListStyle &&<br>
            DerivePointerAlignment == R.DerivePointerAlignment &&<br>
+           DisableFormat == R.DisableFormat &&<br>
            ExperimentalAutoDetectBinPacking ==<br>
                R.ExperimentalAutoDetectBinPacking &&<br>
            ForEachMacros == R.ForEachMacros &&<br>
@@ -473,6 +477,8 @@<br>
            ObjCBlockIndentWidth == R.ObjCBlockIndentWidth &&<br>
            ObjCSpaceAfterProperty == R.ObjCSpaceAfterProperty &&<br>
            ObjCSpaceBeforeProtocolList == R.ObjCSpaceBeforeProtocolList &&<br>
+           PenaltyBreakBeforeFirstCallParameter ==<br>
+               R.PenaltyBreakBeforeFirstCallParameter &&<br>
            PenaltyBreakComment == R.PenaltyBreakComment &&<br>
            PenaltyBreakFirstLessLess == R.PenaltyBreakFirstLessLess &&<br>
            PenaltyBreakString == R.PenaltyBreakString &&<br>
<br>
EMAIL PREFERENCES<br>
  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=RWUOx_h_jYwGryHCjPEjRNA6N30U3DXOuIC5pLwMk20&s=UFYpZ0fgd0D2Z94wj2SVgi_wWfMQumpI5khGbcJwKuA&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>