<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Thu, Jun 25, 2015 at 1:23 PM Meador Inge <<a href="mailto:meadori@gmail.com">meadori@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This fix LGTM, but I do wonder about one thing.  The following pattern seems to occur all over `Sema`:<br>
<br>
  InstantiatingTemplate Inst(*this, PointOfInstantiation, Decl);<br>
    if (Inst.isInvalid())<br>
      ...<br>
<br>
For example, in `Sema::InstantiateEnum`.  Why aren't we marking decls invalid in those other places?<br></blockquote><div><br></div><div>That is exactly what Richard gets at with the solution being to swap the check up a bit instead.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10622&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=Bub0QY9M1HR8HJ9AeS9gsdu_DVplsoNUC5dKtrbH05Q&s=bcdiJX3OmpO0cU37nD-9F58BmgmxtdCbV1iuLTzfXZo&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/D10622</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=Bub0QY9M1HR8HJ9AeS9gsdu_DVplsoNUC5dKtrbH05Q&s=0L9zciD5ZIPWq1BJqRRVIsGscoFDDKV5oBnt-MV97Qs&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
</blockquote></div></div>