<div dir="ltr">SGTM<br><br>(heh, I don't even remember "<span style="font-family:monospace">llvm.dbg.func.start" - maybe that's from before my time... yep, 2009)<br><br>Maybe it'd be nice to make sure that this test doesn't bitrot the same way again - have a canary of some kind? (eg: a non-nodebug function and positively CHECK for the same features - so if those checks ever fail, we know we've accidentally made the negative tests for dbg/DISubprogram invalid)<br><br>Seems weird - not sure if it's a good idea. Just a thought.</span></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jun 25, 2015 at 1:58 PM, Paul Robinson <span dir="ltr"><<a href="mailto:Paul_Robinson@playstation.sony.com" target="_blank">Paul_Robinson@playstation.sony.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi dblaikie, echristo,<br>
<br>
Attirbute 'nodebug' means no llvm.dbg.* intrinsics, no !dbg annotations, and no DISubprogram for the function.<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10747&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=aSyPiv4NHTafMnFjzqXFB2GL0ZWDxIQC8WXy4os4AOw&s=lJgOp2lRgXZVzR7N-oF3Zp_AL7CHZAqFsEaXnETqRZw&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/D10747</a><br>
<br>
Files:<br>
  test/CodeGen/attr-nodebug.c<br>
<br>
Index: test/CodeGen/attr-nodebug.c<br>
===================================================================<br>
--- test/CodeGen/attr-nodebug.c<br>
+++ test/CodeGen/attr-nodebug.c<br>
@@ -1,5 +1,4 @@<br>
-// RUN: %clang_cc1 -g -emit-llvm -o %t %s<br>
-// RUN: not grep 'call void @llvm.dbg.func.start' %t<br>
+// RUN: %clang_cc1 -g -emit-llvm -o - %s | FileCheck %s<br>
<br>
 void t1() __attribute__((nodebug));<br>
<br>
@@ -10,3 +9,10 @@<br>
   a++;<br>
 }<br>
<br>
+// IR should have no llvm.dbg.* calls, or !dbg annotations.<br>
+// CHECK-LABEL: @t1<br>
+// CHECK-NOT:   dbg<br>
+// CHECK:       }<br>
+<br>
+// And no function description for debug info.<br>
+// CHECK-NOT: DISubprogram<br>
<br>
EMAIL PREFERENCES<br>
  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=aSyPiv4NHTafMnFjzqXFB2GL0ZWDxIQC8WXy4os4AOw&s=ru5kYy1bbiTyJAaXbkF6KcXtds1PiwI_LEtzc8VOaUs&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
</blockquote></div><br></div>