<p dir="ltr">Lgtm</p>
<p dir="ltr">Sent from phone</p>
<div class="gmail_quote">On Jun 19, 2015 5:14 PM, "Davide Italiano" <<a href="mailto:dccitaliano@gmail.com">dccitaliano@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Reordered checks as suggested.<br>
Anders Carlsson LGTM'd the change. Reid, do you think we can go forward and check this in?<br>
<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10508&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=CMsTRbBq4LXXg0co5PUeKoZ_WzCt-uR2-0JcWivtszg&s=MwdZUrMyprkiQAVUvUbvRneB9JW8_2l3QzEIz91sTPI&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/D10508</a><br>
<br>
Files:<br>
  lib/CodeGen/CGClass.cpp<br>
  test/CodeGenCXX/destructor-crash.cpp<br>
<br>
Index: lib/CodeGen/CGClass.cpp<br>
===================================================================<br>
--- lib/CodeGen/CGClass.cpp<br>
+++ lib/CodeGen/CGClass.cpp<br>
@@ -1297,6 +1297,10 @@<br>
   if (BaseClassDecl->hasTrivialDestructor())<br>
     return true;<br>
<br>
+  // Give up if the destructor is not accessible.<br>
+  if (!BaseClassDecl->getDestructor())<br>
+    return false;<br>
+<br>
   if (!BaseClassDecl->getDestructor()->hasTrivialBody())<br>
     return false;<br>
<br>
Index: test/CodeGenCXX/destructor-crash.cpp<br>
===================================================================<br>
--- test/CodeGenCXX/destructor-crash.cpp<br>
+++ test/CodeGenCXX/destructor-crash.cpp<br>
@@ -0,0 +1,19 @@<br>
+// RUN: %clang_cc1 %s -emit-llvm -std=c++11 -o %t<br>
+<br>
+struct A {<br>
+  ~A();<br>
+};<br>
+<br>
+struct B {<br>
+  A a;<br>
+};<br>
+<br>
+struct C {<br>
+  union {<br>
+    B b;<br>
+  };<br>
+<br>
+  ~C() noexcept;<br>
+};<br>
+<br>
+C::~C() noexcept {}<br>
<br>
EMAIL PREFERENCES<br>
  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=CMsTRbBq4LXXg0co5PUeKoZ_WzCt-uR2-0JcWivtszg&s=8P8gNWFsVaMizKOUqduP36M1sbRST_KyT8N70BsUPgA&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
</blockquote></div>