<div dir="ltr">Done in r239816.</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 16, 2015 at 3:04 PM, Tobias Grosser <span dir="ltr"><<a href="mailto:tobias@grosser.es" target="_blank">tobias@grosser.es</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 06/16/2015 12:22 PM, Daniel Jasper wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: djasper<br>
Date: Tue Jun 16 05:22:10 2015<br>
New Revision: 239809<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D239809-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=nJMuN5w6JptxqfVj-QbtOiFDcRHANiCz576-Sf46jdE&s=O09u6A-ZzPYwhYj6DHWbaTJKnSn8wUZkpRnk0FV3ReA&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=239809&view=rev</a><br>
Log:<br>
Tooling: When applying a set of replacements, do deletions before<br>
insertions. It is unlikely to be the intention to delete parts of newly<br>
inserted code. To do so, changed sorting Replacements at the same offset<br>
to have decreasing length.<br>
</blockquote>
<br></span>
This seems to have broken some testers which are running with gcc 4.7.2:<br>
<br>
/home/grosser/buildslave/perf-x86_64-penryn-O3-polly-fast/llvm.src/tools/clang/unittests/Tooling/RewriterTest.cpp: In member function ‘virtual void clang::tooling::{anonymous}::Rewriter_AdjacentInsertAndDelete_Test::TestBody()’:<br>
/home/grosser/buildslave/perf-x86_64-penryn-O3-polly-fast/llvm.src/tools/clang/unittests/Tooling/RewriterTest.cpp:42:12: error: ‘clang::tooling::Replacements’ has no member named ‘emplace’<br>
/home/grosser/buildslave/perf-x86_64-penryn-O3-polly-fast/llvm.src/tools/clang/unittests/Tooling/RewriterTest.cpp:43:12: error: ‘clang::tooling::Replacements’ has no member named ‘emplace’<br>
/bin/rm: cannot remove `/home/grosser/buildslave/perf-x86_64-penryn-O3-polly-fast/llvm.obj/tools/clang/unittests/Tooling/Release+Asserts/RewriterTest.d.tmp': No such file or directory<br>
make[4]: *** [/home/grosser/buildslave/perf-x86_64-penryn-O3-polly-fast/llvm.obj/tools/clang/unittests/Tooling/Release+Asserts/RewriterTest.o] Error 1<br>
make[4]: Leaving directory `/home/grosser/buildslave/perf-x86_64-penryn-O3-polly-fast/llvm.obj/tools/clang/unittests/Tooling'<br>
<br>
LLVM is documented to work with gcc 4.7.0 [1], so we may consider fixing this (the fix is simple).<br>
<br>
Best,<br>
Tobias<br>
<br>
[1] <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_docs_GettingStarted.html-23software&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=nJMuN5w6JptxqfVj-QbtOiFDcRHANiCz576-Sf46jdE&s=Wgx_ZemS5jivyO6HiONO9IGLACFwNN2ane_0RkVfCXM&e=" rel="noreferrer" target="_blank">http://llvm.org/docs/GettingStarted.html#software</a><div class="HOEnZb"><div class="h5"><br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div>