<p dir="ltr">Mentioning the benchmark you used in the description would have been helpful to see what we get for the extra complexity.<br>
</p>
<br><div class="gmail_quote"><div dir="ltr">On Fri, Jun 12, 2015, 3:15 PM Benjamin Kramer <<a href="mailto:benny.kra@googlemail.com">benny.kra@googlemail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: d0k<br>
Date: Fri Jun 12 08:06:57 2015<br>
New Revision: 239604<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D239604-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=LHxlkHP1T5iVGZHS9bdyKwra543p6rZ0vbQz4K6mZk0&s=NoBj3sq0J0TBv3x9-6i-n_j2qQbvIHfn0-pfxV7Fz1w&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=239604&view=rev</a><br>
Log:<br>
[clang-format] Hoist vector allocation out of loop. NFC.<br>
<br>
Modified:<br>
    cfe/trunk/lib/Format/FormatToken.cpp<br>
<br>
Modified: cfe/trunk/lib/Format/FormatToken.cpp<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_lib_Format_FormatToken.cpp-3Frev-3D239604-26r1-3D239603-26r2-3D239604-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=LHxlkHP1T5iVGZHS9bdyKwra543p6rZ0vbQz4K6mZk0&s=ibnr57u9NfARSvnCM4Ea7JlahtFlPVJ6YT9pRwHlQZQ&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Format/FormatToken.cpp?rev=239604&r1=239603&r2=239604&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Format/FormatToken.cpp (original)<br>
+++ cfe/trunk/lib/Format/FormatToken.cpp Fri Jun 12 08:06:57 2015<br>
@@ -203,11 +203,14 @@ void CommaSeparatedList::precomputeForma<br>
<br>
   // We can never place more than ColumnLimit / 3 items in a row (because of the<br>
   // spaces and the comma).<br>
-  for (unsigned Columns = 1; Columns <= Style.ColumnLimit / 3; ++Columns) {<br>
+  unsigned MaxItems = Style.ColumnLimit / 3;<br>
+  std::vector<unsigned> MinSizeInColumn;<br>
+  MinSizeInColumn.reserve(MaxItems);<br>
+  for (unsigned Columns = 1; Columns <= MaxItems; ++Columns) {<br>
     ColumnFormat Format;<br>
     Format.Columns = Columns;<br>
     Format.ColumnSizes.resize(Columns);<br>
-    std::vector<unsigned> MinSizeInColumn(Columns, UINT_MAX);<br>
+    MinSizeInColumn.assign(Columns, UINT_MAX);<br>
     Format.LineCount = 1;<br>
     bool HasRowWithSufficientColumns = false;<br>
     unsigned Column = 0;<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>