<div dir="ltr">LGTM</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jun 12, 2015 at 12:46 PM, Hans Wennborg <span dir="ltr"><<a href="mailto:hans@chromium.org" target="_blank">hans@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi rnk, rsmith, majnemer,<br>
<br>
The underlying problem in PR23823 already existed before my recent change in r239558, but that change made it worse (failing not only for undeclared symbols, but also failed overload resolution). This makes us not try to delay the lookup in SFINAE context. I assume no current code is relying on SFINAE working with lookups that need to be delayed, because that never seems to have worked :-)<br>
<br>
Please take a look!<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10417&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=KoHmI0V-G9tgR2ziKlyA7Tn0lOB4R-FICF3tGnX5ojA&s=wOk_RzseaEYopHjSUxPOAu4UjcbOWDzxPdBQzSWBc6Q&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/D10417</a><br>
<br>
Files:<br>
  lib/Sema/SemaOverload.cpp<br>
  test/SemaTemplate/ms-lookup-template-base-classes.cpp<br>
<br>
Index: lib/Sema/SemaOverload.cpp<br>
===================================================================<br>
--- lib/Sema/SemaOverload.cpp<br>
+++ lib/Sema/SemaOverload.cpp<br>
@@ -10750,7 +10750,8 @@<br>
   // functions, including those from argument-dependent lookup.<br>
   AddOverloadedCallCandidates(ULE, Args, *CandidateSet);<br>
<br>
-  if (getLangOpts().MSVCCompat && CurContext->isDependentContext() &&<br>
+  if (getLangOpts().MSVCCompat &&<br>
+      CurContext->isDependentContext() && !isSFINAEContext() &&<br>
       (isa<FunctionDecl>(CurContext) || isa<CXXRecordDecl>(CurContext))) {<br>
<br>
     OverloadCandidateSet::iterator Best;<br>
Index: test/SemaTemplate/ms-lookup-template-base-classes.cpp<br>
===================================================================<br>
--- test/SemaTemplate/ms-lookup-template-base-classes.cpp<br>
+++ test/SemaTemplate/ms-lookup-template-base-classes.cpp<br>
@@ -563,3 +563,13 @@<br>
   x.member(); // expected-note{{requested here}}<br>
 };<br>
 }<br>
+<br>
+namespace PR23823 {<br>
+// Don't delay lookup in SFINAE context.<br>
+template <typename T> decltype(g(T())) check(); // expected-note{{candidate template ignored: substitution failure [with T = int]: use of undeclared identifier 'g'}}<br>
+decltype(check<int>()) x; // expected-error{{no matching function for call to 'check'}}<br>
+<br>
+void h();<br>
+template <typename T> decltype(h(T())) check2(); // expected-note{{candidate template ignored: substitution failure [with T = int]: no matching function for call to 'h'}}<br>
+decltype(check2<int>()) y; // expected-error{{no matching function for call to 'check2'}}<br>
+}<br>
<br>
EMAIL PREFERENCES<br>
  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=KoHmI0V-G9tgR2ziKlyA7Tn0lOB4R-FICF3tGnX5ojA&s=0q2MJ4YZ0t2RMLNUgaljZcMntAfw_yZiavCVcHkINoI&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
</blockquote></div><br></div>