<div dir="ltr">I honestly think the right approach here is to substitute our own robust implementation of rm on Windows. We can do it in the lit shell emulator.</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 9, 2015 at 10:53 AM, Reid Kleckner <span dir="ltr"><<a href="mailto:rnk@google.com" target="_blank">rnk@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">This came up last week:<div><a href="http://lists.cs.uiuc.edu/pipermail/cfe-dev/2015-June/043376.html" target="_blank">http://lists.cs.uiuc.edu/pipermail/cfe-dev/2015-June/043376.html</a><br></div><div><br></div><div>I just disabled the test in r239416.</div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 9, 2015 at 5:41 AM, Benjamin Kramer <span dir="ltr"><<a href="mailto:benny.kra@googlemail.com" target="_blank">benny.kra@googlemail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: d0k<br>
Date: Tue Jun  9 07:41:02 2015<br>
New Revision: 239402<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D239402-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=VNosFTXTOOh4fWyBW7WaX8ATFx0TnhEdIu5uVQ1ZTvg&s=Z7HmXmvIJifaOLR0913Cj_HYwUQH0UsIMCE-WHo7DG8&e=" target="_blank">http://llvm.org/viewvc/llvm-project?rev=239402&view=rev</a><br>
Log:<br>
Remove rm invocations where the file is immediately rewritten later.<br>
<br>
This may or may not help making this test less flaky on windows. There's<br>
a race condition in lit somewhere.<br>
<br>
Modified:<br>
    cfe/trunk/test/Format/style-on-command-line.cpp<br>
<br>
Modified: cfe/trunk/test/Format/style-on-command-line.cpp<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_test_Format_style-2Don-2Dcommand-2Dline.cpp-3Frev-3D239402-26r1-3D239401-26r2-3D239402-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=VNosFTXTOOh4fWyBW7WaX8ATFx0TnhEdIu5uVQ1ZTvg&s=E8j8uya6ep20po3L_ze3q4HEyY27nD9hAZGDLUPpDVc&e=" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Format/style-on-command-line.cpp?rev=239402&r1=239401&r2=239402&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/Format/style-on-command-line.cpp (original)<br>
+++ cfe/trunk/test/Format/style-on-command-line.cpp Tue Jun  9 07:41:02 2015<br>
@@ -3,13 +3,11 @@<br>
 // RUN: clang-format -style="{BasedOnStyle: LLVM, IndentWidth: 7}" %t.cpp | FileCheck -strict-whitespace -check-prefix=CHECK2 %s<br>
 // RUN: clang-format -style="{BasedOnStyle: invalid, IndentWidth: 7}" -fallback-style=LLVM %t.cpp 2>&1 | FileCheck -strict-whitespace -check-prefix=CHECK3 %s<br>
 // RUN: clang-format -style="{lsjd}" %t.cpp -fallback-style=LLVM 2>&1 | FileCheck -strict-whitespace -check-prefix=CHECK4 %s<br>
-// RUN: [ ! -e %T/.clang-format ] || rm %T/.clang-format<br>
 // RUN: printf "BasedOnStyle: google\nIndentWidth: 5\n" > %T/.clang-format<br>
 // RUN: clang-format -style=file %t.cpp 2>&1 | FileCheck -strict-whitespace -check-prefix=CHECK5 %s<br>
 // RUN: printf "\n" > %T/.clang-format<br>
 // RUN: clang-format -style=file -fallback-style=webkit %t.cpp 2>&1 | FileCheck -strict-whitespace -check-prefix=CHECK6 %s<br>
-// RUN: [ ! -e %T/.clang-format ] || rm %T/.clang-format<br>
-// RUN: [ ! -e %T/_clang-format ] || rm %T/_clang-format<br>
+// RUN: rm %T/.clang-format<br>
 // RUN: printf "BasedOnStyle: google\nIndentWidth: 6\n" > %T/_clang-format<br>
 // RUN: clang-format -style=file %t.cpp 2>&1 | FileCheck -strict-whitespace -check-prefix=CHECK7 %s<br>
 // RUN: clang-format -style="{BasedOnStyle: LLVM, PointerBindsToType: true}" %t.cpp | FileCheck -strict-whitespace -check-prefix=CHECK8 %s<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>