<div dir="ltr">This warns on C-style casts, which it should not:<div><div>$ ninja check</div><div>[68/414] Building CXX object lib\ExecutionEngine\RuntimeDyld\CMakeFiles\LLVMRuntimeDyld.dir\RTDyldMemoryManager.cpp.obj</div><div>..\lib\ExecutionEngine\RuntimeDyld\RTDyldMemoryManager.cpp(61,6) : warning: static_cast between pointer-to-function and pointer-to-object is a Microsoft extension [-Wmicrosoft]</div><div> ((void (*)(void *))rf)(p);</div><div> ^~~~~~~~~~~~~~~~~~~~</div><div>..\lib\ExecutionEngine\RuntimeDyld\RTDyldMemoryManager.cpp(74,6) : warning: static_cast between pointer-to-function and pointer-to-object is a Microsoft extension [-Wmicrosoft]</div><div> ((void (*)(void *))df)(p);</div><div> ^~~~~~~~~~~~~~~~~~~~</div><div>2 warnings generated.</div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 2, 2015 at 3:15 PM, David Majnemer <span dir="ltr"><<a href="mailto:david.majnemer@gmail.com" target="_blank">david.majnemer@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: majnemer<br>
Date: Tue Jun 2 17:15:12 2015<br>
New Revision: 238877<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D238877-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=IWumhRtVxgkBy94TJmGJlzSm_USVEinNfChukOvYHXs&s=Qo5Y0Yie1ZQ5xek1xMVi8-vHimj6-gfQKMSoBNjczHo&e=" target="_blank">http://llvm.org/viewvc/llvm-project?rev=238877&view=rev</a><br>
Log:<br>
[MSVC Compatibility] Permit static_cast from void-ptr to function-ptr<br>
<br>
The MSVC 2013 and 2015 implementation of std::atomic is specialized for<br>
pointer types. The member functions are implemented using a static_cast<br>
from void-ptr to function-ptr which is not allowed in the standard.<br>
Permit this conversion if -fms-compatibility is present.<br>
<br>
This fixes PR23733.<br>
<br>
Modified:<br>
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td<br>
cfe/trunk/lib/Sema/SemaCast.cpp<br>
cfe/trunk/test/SemaCXX/MicrosoftCompatibility-cxx98.cpp<br>
<br>
Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_include_clang_Basic_DiagnosticSemaKinds.td-3Frev-3D238877-26r1-3D238876-26r2-3D238877-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=IWumhRtVxgkBy94TJmGJlzSm_USVEinNfChukOvYHXs&s=YEljn7aMoFxV5br8_mRcHGozVZI-QqvIMiHp42MhJjo&e=" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td?rev=238877&r1=238876&r2=238877&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td (original)<br>
+++ cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Tue Jun 2 17:15:12 2015<br>
@@ -5390,6 +5390,10 @@ def err_bad_const_cast_dest : Error<<br>
"which is not a reference, pointer-to-object, or pointer-to-data-member">;<br>
def ext_cast_fn_obj : Extension<<br>
"cast between pointer-to-function and pointer-to-object is an extension">;<br>
+def ext_ms_cast_fn_obj : ExtWarn<<br>
+ "static_cast between pointer-to-function and pointer-to-object is a "<br>
+ "Microsoft extension">,<br>
+ InGroup<Microsoft>;<br>
def warn_cxx98_compat_cast_fn_obj : Warning<<br>
"cast between pointer-to-function and pointer-to-object is incompatible with C++98">,<br>
InGroup<CXX98CompatPedantic>, DefaultIgnore;<br>
<br>
Modified: cfe/trunk/lib/Sema/SemaCast.cpp<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_lib_Sema_SemaCast.cpp-3Frev-3D238877-26r1-3D238876-26r2-3D238877-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=IWumhRtVxgkBy94TJmGJlzSm_USVEinNfChukOvYHXs&s=tEwafYc5cVQ7y9_CxVOrF8QPfFqLyqiXm8yffhn96vo&e=" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaCast.cpp?rev=238877&r1=238876&r2=238877&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Sema/SemaCast.cpp (original)<br>
+++ cfe/trunk/lib/Sema/SemaCast.cpp Tue Jun 2 17:15:12 2015<br>
@@ -1081,6 +1081,14 @@ static TryCastResult TryStaticCast(Sema<br>
Kind = CK_BitCast;<br>
return TC_Success;<br>
}<br>
+<br>
+ // Microsoft permits static_cast from 'pointer-to-void' to<br>
+ // 'pointer-to-function'.<br>
+ if (Self.getLangOpts().MSVCCompat && DestPointee->isFunctionType()) {<br>
+ Self.Diag(OpRange.getBegin(), diag::ext_ms_cast_fn_obj) << OpRange;<br>
+ Kind = CK_BitCast;<br>
+ return TC_Success;<br>
+ }<br>
}<br>
else if (DestType->isObjCObjectPointerType()) {<br>
// allow both c-style cast and static_cast of objective-c pointers as<br>
<br>
Modified: cfe/trunk/test/SemaCXX/MicrosoftCompatibility-cxx98.cpp<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_test_SemaCXX_MicrosoftCompatibility-2Dcxx98.cpp-3Frev-3D238877-26r1-3D238876-26r2-3D238877-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=IWumhRtVxgkBy94TJmGJlzSm_USVEinNfChukOvYHXs&s=V8XQH_z2YZl_fsYDlRNGVpIY_WM_C_ODyWLUKj5Sid4&e=" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/MicrosoftCompatibility-cxx98.cpp?rev=238877&r1=238876&r2=238877&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/SemaCXX/MicrosoftCompatibility-cxx98.cpp (original)<br>
+++ cfe/trunk/test/SemaCXX/MicrosoftCompatibility-cxx98.cpp Tue Jun 2 17:15:12 2015<br>
@@ -6,3 +6,5 @@ enum ENUM; // expected-warning {{forward<br>
ENUM *var = 0;<br>
ENUM var2 = (ENUM)3;<br>
enum ENUM1* var3 = 0;// expected-warning {{forward references to 'enum' types are a Microsoft extension}}<br>
+<br>
+void (*PR23733)() = static_cast<void (*)()>((void *)0); // expected-warning {{static_cast between pointer-to-function and pointer-to-object is a Microsoft extension}}<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>