<div dir="ltr"><div>Thank you! Could you close the bug as well?</div><div>And maybe you can look at <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__llvm.org_bugs_show-5Fbug.cgi-3Fid-3D22880&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=UyHXa15jNZoCuWSowTb3S9FB6rFBt4Xqt53fK4Q1HEA&s=tZVQpePDxVzi6CDlJZicafSLN4v3SYfdpXFQRSK5qfg&e=">https://llvm.org/bugs/show_bug.cgi?id=22880</a>?<br><div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, May 29, 2015 at 12:04 PM, Szabolcs Sipos <span dir="ltr"><<a href="mailto:szabolcs.sipos@ericsson.com" target="_blank">szabolcs.sipos@ericsson.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Committed in r238548.<br>
<span class=""><br>
<br>
================<br>
Comment at: clang-tidy/misc/AssertSideEffectCheck.cpp:59<br>
@@ +58,3 @@<br>
+    if (const auto *FuncDecl = CExpr->getDirectCallee()) {<br>
+      const std::string FunctionName = FuncDecl->getNameInfo().getAsString();<br>
+      if (FunctionName == "__builtin_expect") // exceptions come here<br>
----------------<br>
</span><span class="">alexfh wrote:<br>
> There's no need to use `getAsString()`, as you're only checking whether it's a specific unqualified name. I'd try to use the more effective version: `getName()`. Something along the lines of:<br>
><br>
>   if (FuncDecl->getDeclName().isIdentifier() && FuncDecl->getName() == "...")<br>
>     ...<br>
</span>Thanks. Changed it as you suggested.<br>
<div class=""><div class="h5"><br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D9959&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=UyHXa15jNZoCuWSowTb3S9FB6rFBt4Xqt53fK4Q1HEA&s=NxolLSEfVpiDagbw--1EcIOv5Ywq3mUabJofwlsOG2s&e=" target="_blank">http://reviews.llvm.org/D9959</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=UyHXa15jNZoCuWSowTb3S9FB6rFBt4Xqt53fK4Q1HEA&s=dHYczaWldOsQ3bg-xVa9X1IUQlXgAz-Dip0ewueKhvA&e=" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
</div></div></blockquote></div><div><br></div>
</div></div></div></div>