<div dir="ltr"><div class="gmail_quote">On Tue, May 26, 2015 at 7:54 PM David Majnemer <<a href="mailto:david.majnemer@gmail.com">david.majnemer@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, May 26, 2015 at 7:22 PM, Chaoren Lin <span dir="ltr"><<a href="mailto:chaorenl@google.com" target="_blank">chaorenl@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div>Hi David,</div><div><br></div><div>Thanks for your concern.</div><div><br></div><div>The commit was intentional. I was hoping this small commit would fall under this part:</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">smaller changes can be reviewed after commit</blockquote><div><br></div><div>of the <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_docs_DeveloperPolicy.html-23code-2Dreviews&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=QuAaZphRKuyHP5n6oQVKXZjT9Q798WxBKrlU6YLePNI&s=ohuT68Er4qKRMq9onem2NyWK1BuTEIbtX1YABHqMsys&e=" target="_blank">LLVM Developer Policy</a></div></div></blockquote><div><br></div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>I'm afraid it doesn't because of the following proviso:</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Code review can be an iterative process, which continues until the patch is ready to be committed. Specifically, once a patch is sent out for review, it needs an explicit “looks good” before it is submitted. Do not assume silent approval, or request active objections to the patch with a deadline.</blockquote></div></div></div></blockquote><div><br></div><div>This section is just confusing.</div><div><br></div><div>Slightly better wording is here: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_docs_DeveloperPolicy.html-23obtaining-2Dcommit-2Daccess&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=YwkiC3qXOS22R4XDwSvhcJZZsG1FyOdIBz4BK_4POZI&s=GE_VKJVwBLXruw78Ate_eT0OhsStu756tnFRgNzqn6U&e=">http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access</a></div><div><br></div><div>This establishes the guideline of 'obvious'. I don't think any change I make (other than fixing the spelling of a comment) to a project I don't routinely contribute to would be "obvious" to me.</div><div><br></div><div>The "small" and "obvious" wording aren't clear (I'll work to update the docs here) but I think they are supposed to cover the same set of changes, and I don't think they would cover any changes to a project you have little or no experience with previously.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> </div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div><br></div><div>We inlined a copy of this file in LLDB for Windows, and I ran into a problem where any mangled names with pointers or references in their argument list would cause a crash. Turns out that on Linux, String::front() consistently returns '\0' when empty, even though it should be undefined behavior. </div></div></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div><br></div><div>It should be covered by existing tests if you enable asserts for libcxx and try to demangle "_Z1FPiRiOiMS0_FiiE".</div></div></blockquote><div><br></div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>I don't see an existing test which tries to demangle '_Z1FPiRiOiMS0_FiiE'. I think you should add it to test/test_demangle.pass.cpp</div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div><br></div><div>Thanks,</div><div>Chaoren</div></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 26, 2015 at 4:43 PM, David Majnemer <span dir="ltr"><<a href="mailto:david.majnemer@gmail.com" target="_blank">david.majnemer@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">I didn't see anyone LGTM the phabricator review and no test has been added for this change. Perhaps you accidentally committed this?<div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 26, 2015 at 4:14 PM, Chaoren Lin <span dir="ltr"><<a href="mailto:chaorenl@google.com" target="_blank">chaorenl@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: chaoren<br>
Date: Tue May 26 18:14:26 2015<br>
New Revision: 238263<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D238263-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=QuAaZphRKuyHP5n6oQVKXZjT9Q798WxBKrlU6YLePNI&s=dc2o1Gcmar0Ia3dwUAnef8_iONKHEibRLQHcMRxRVZU&e=" target="_blank">http://llvm.org/viewvc/llvm-project?rev=238263&view=rev</a><br>
Log:<br>
Make sure !empty() before calling String::front().<br>
<br>
Reviewers: howard.hinnant<br>
<br>
Subscribers: cfe-commits<br>
<br>
Differential Revision: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D9954&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=QuAaZphRKuyHP5n6oQVKXZjT9Q798WxBKrlU6YLePNI&s=14VS6SUFIr2KjQuuTaWrupP-uks0B0Rrd9sohLh_25M&e=" target="_blank">http://reviews.llvm.org/D9954</a><br>
<br>
Modified:<br>
libcxxabi/trunk/src/cxa_demangle.cpp<br>
<br>
Modified: libcxxabi/trunk/src/cxa_demangle.cpp<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_libcxxabi_trunk_src_cxa-5Fdemangle.cpp-3Frev-3D238263-26r1-3D238262-26r2-3D238263-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=QuAaZphRKuyHP5n6oQVKXZjT9Q798WxBKrlU6YLePNI&s=ygHBZOgwMcNkc7vMWXBjIett4-76FeOUf8fbbVzhxDk&e=" target="_blank">http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/src/cxa_demangle.cpp?rev=238263&r1=238262&r2=238263&view=diff</a><br>
==============================================================================<br>
--- libcxxabi/trunk/src/cxa_demangle.cpp (original)<br>
+++ libcxxabi/trunk/src/cxa_demangle.cpp Tue May 26 18:14:26 2015<br>
@@ -1671,7 +1671,7 @@ parse_pointer_to_member_type(const char*<br>
auto func = std::move(db.names.back());<br>
db.names.pop_back();<br>
auto class_type = std::move(db.names.back());<br>
- if (func.second.front() == '(')<br>
+ if (!func.second.empty() && func.second.front() == '(')<br>
{<br>
db.names.back().first = std::move(func.first) + "(" + class_type.move_full() + "::*";<br>
db.names.back().second = ")" + std::move(func.second);<br>
@@ -2018,7 +2018,8 @@ parse_type(const char* first, const char<br>
db.names[k].first += " (";<br>
db.names[k].second.insert(0, ")");<br>
}<br>
- else if (db.names[k].second.front() == '(')<br>
+ else if (!db.names[k].second.empty() &&<br>
+ db.names[k].second.front() == '(')<br>
{<br>
db.names[k].first += "(";<br>
db.names[k].second.insert(0, ")");<br>
@@ -2045,7 +2046,8 @@ parse_type(const char* first, const char<br>
db.names[k].first += " (";<br>
db.names[k].second.insert(0, ")");<br>
}<br>
- else if (db.names[k].second.front() == '(')<br>
+ else if (!db.names[k].second.empty() &&<br>
+ db.names[k].second.front() == '(')<br>
{<br>
db.names[k].first += "(";<br>
db.names[k].second.insert(0, ")");<br>
@@ -2079,7 +2081,8 @@ parse_type(const char* first, const char<br>
db.names[k].first += " (";<br>
db.names[k].second.insert(0, ")");<br>
}<br>
- else if (db.names[k].second.front() == '(')<br>
+ else if (!db.names[k].second.empty() &&<br>
+ db.names[k].second.front() == '(')<br>
{<br>
db.names[k].first += "(";<br>
db.names[k].second.insert(0, ")");<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>
</blockquote></div><br></div>
</div></div></blockquote></div></div></div>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div></div>