<div dir="ltr">I didn't see anyone LGTM the phabricator review and no test has been added for this change.  Perhaps you accidentally committed this?<div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 26, 2015 at 4:14 PM, Chaoren Lin <span dir="ltr"><<a href="mailto:chaorenl@google.com" target="_blank">chaorenl@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: chaoren<br>
Date: Tue May 26 18:14:26 2015<br>
New Revision: 238263<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D238263-26view-3Drev&d=AwMGaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=iDWZBgxidJRr4OklLMZrIvMHfpZXE8VjsGUQdD9IDiM&s=lgtDHYjJNHgprv-QEGP9WbUb3KdWIXuzMrFPLPBReyE&e=" target="_blank">http://llvm.org/viewvc/llvm-project?rev=238263&view=rev</a><br>
Log:<br>
Make sure !empty() before calling String::front().<br>
<br>
Reviewers: howard.hinnant<br>
<br>
Subscribers: cfe-commits<br>
<br>
Differential Revision: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D9954&d=AwMGaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=iDWZBgxidJRr4OklLMZrIvMHfpZXE8VjsGUQdD9IDiM&s=ELeRsQaKRLcGJ82m_BYhfVF3aCI9zcc2c5sSHhU8kvU&e=" target="_blank">http://reviews.llvm.org/D9954</a><br>
<br>
Modified:<br>
    libcxxabi/trunk/src/cxa_demangle.cpp<br>
<br>
Modified: libcxxabi/trunk/src/cxa_demangle.cpp<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_libcxxabi_trunk_src_cxa-5Fdemangle.cpp-3Frev-3D238263-26r1-3D238262-26r2-3D238263-26view-3Ddiff&d=AwMGaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=iDWZBgxidJRr4OklLMZrIvMHfpZXE8VjsGUQdD9IDiM&s=cxqGK1VqwxmEZYXAcjAW_ZZaApn0mygeZD2q07yX6ps&e=" target="_blank">http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/src/cxa_demangle.cpp?rev=238263&r1=238262&r2=238263&view=diff</a><br>
==============================================================================<br>
--- libcxxabi/trunk/src/cxa_demangle.cpp (original)<br>
+++ libcxxabi/trunk/src/cxa_demangle.cpp Tue May 26 18:14:26 2015<br>
@@ -1671,7 +1671,7 @@ parse_pointer_to_member_type(const char*<br>
                 auto func = std::move(db.names.back());<br>
                 db.names.pop_back();<br>
                 auto class_type = std::move(db.names.back());<br>
-                if (func.second.front() == '(')<br>
+                if (!func.second.empty() && func.second.front() == '(')<br>
                 {<br>
                     db.names.back().first = std::move(func.first) + "(" + class_type.move_full() + "::*";<br>
                     db.names.back().second = ")" + std::move(func.second);<br>
@@ -2018,7 +2018,8 @@ parse_type(const char* first, const char<br>
                                     db.names[k].first += " (";<br>
                                     db.names[k].second.insert(0, ")");<br>
                                 }<br>
-                                else if (db.names[k].second.front() == '(')<br>
+                                else if (!db.names[k].second.empty() &&<br>
+                                          db.names[k].second.front() == '(')<br>
                                 {<br>
                                     db.names[k].first += "(";<br>
                                     db.names[k].second.insert(0, ")");<br>
@@ -2045,7 +2046,8 @@ parse_type(const char* first, const char<br>
                                     db.names[k].first += " (";<br>
                                     db.names[k].second.insert(0, ")");<br>
                                 }<br>
-                                else if (db.names[k].second.front() == '(')<br>
+                                else if (!db.names[k].second.empty() &&<br>
+                                          db.names[k].second.front() == '(')<br>
                                 {<br>
                                     db.names[k].first += "(";<br>
                                     db.names[k].second.insert(0, ")");<br>
@@ -2079,7 +2081,8 @@ parse_type(const char* first, const char<br>
                                     db.names[k].first += " (";<br>
                                     db.names[k].second.insert(0, ")");<br>
                                 }<br>
-                                else if (db.names[k].second.front() == '(')<br>
+                                else if (!db.names[k].second.empty() &&<br>
+                                          db.names[k].second.front() == '(')<br>
                                 {<br>
                                     db.names[k].first += "(";<br>
                                     db.names[k].second.insert(0, ")");<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>