<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" id="owaParaStyle"></style>
</head>
<body fpstyle="1" ocsi="0">
<div style="direction: ltr;font-family: Times New Roman;color: #000000;font-size: 12pt;">
<br>
<div style="font-family: Times New Roman; color: #000000; font-size: 16px">
<hr tabindex="-1">
<div id="divRpF368708" style="direction: ltr;"><font face="Tahoma" size="2" color="#000000"><b>From:</b> Alexander Kornienko [alexfh@google.com]<br>
<b>Sent:</b> Tuesday, May 26, 2015 5:49 PM<br>
<b>To:</b> H.J. Lu<br>
<b>Cc:</b> Petar Jovanovic; cfe-commits@cs.uiuc.edu cfe<br>
<b>Subject:</b> Re: r238200 - [MIPS] fix extension of integer types (function calls)<br>
</font><br>
</div>
<div></div>
<div>
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">On Tue, May 26, 2015 at 5:20 PM, H.J. Lu <span dir="ltr">
<<a href="mailto:hjl.tools@gmail.com" target="_blank">hjl.tools@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex; border-left-width:1px; border-left-color:rgb(204,204,204); border-left-style:solid; padding-left:1ex">
<span class="">On Tue, May 26, 2015 at 6:30 AM, Petar Jovanovic<br>
<<a href="mailto:petar.jovanovic@imgtec.com" target="_blank">petar.jovanovic@imgtec.com</a>> wrote:<br>
> Author: petarj<br>
> Date: Tue May 26 08:30:54 2015<br>
> New Revision: 238200<br>
><br>
> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D238200-26view-3Drev&d=AwMFAw&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=Kil6wfkf7yG4Ymv8KBC6crOcLGs6nR5e3-_i41Rp4nc&s=v_nQAuKvXHQgT-fb7HSx_FDpqoz4wWODELEFdJo_9eM&e=" target="_blank">
http://llvm.org/viewvc/llvm-project?rev=238200&view=rev</a><br>
> Log:<br>
> [MIPS] fix extension of integer types (function calls)<br>
><br>
> On MIPS unsigned int type should not be zero extended but sign-extended.<br>
><br>
> Patch by Strahinja Petrovic.<br>
><br>
> Differential Revision: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D9198&d=AwMFAw&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=Kil6wfkf7yG4Ymv8KBC6crOcLGs6nR5e3-_i41Rp4nc&s=CrnEWP5qno9g4-zxTFircjtVkkvVzZTZijmOT1lyJLU&e=" target="_blank">
http://reviews.llvm.org/D9198</a><br>
><br>
> Added:<br>
> cfe/trunk/test/CodeGen/mips-unsigned-ext-var.c<br>
> cfe/trunk/test/CodeGen/mips-unsigned-extend.c<br>
> Modified:<br>
> cfe/trunk/lib/CodeGen/ABIInfo.h<br>
> cfe/trunk/lib/CodeGen/CGCall.cpp<br>
> cfe/trunk/lib/CodeGen/TargetInfo.cpp<br>
> cfe/trunk/test/CodeGen/atomics-inlining.c<br>
> cfe/trunk/test/CodeGenCXX/mips-size_t-ptrdiff_t.cpp<br>
><br>
<br>
</span>On Fedora 20/x86-64, I got<br>
<br>
/export/gnu/import/git/llvm/tools/clang/test/CodeGen/mips-unsigned-extend.c:13:9:<br>
error: expected string not found in input<br>
<span class="">// N64: call void @foo(i32 signext %0)<br>
</span> ^<br>
<stdin>:1:1: note: scanning from here<br>
; ModuleID = '/export/gnu/import/git/llvm/tools/clang/test/CodeGen/mips-unsigned-extend.c'<br>
^<br>
<stdin>:17:2: note: possible intended match here<br>
call void @foo(i32 signext %1)<br>
</blockquote>
<div><br>
</div>
<div><br>
</div>
<div>> Same here. </div>
<div><br>
</div>
<div>> And additionally the mips-unsigned-ext-var.c test fails:</div>
</div>
</div>
<blockquote style="margin:0 0 0 40px; border:none; padding:0px">
<div class="gmail_extra">
<div class="gmail_quote">
<div>
<div><br>
</div>
<div> clang/test/CodeGen/mips-unsigned-ext-var.c:5:10: fatal error: 'stdarg.h' file not found</div>
</div>
</div>
</div>
<div class="gmail_extra">
<div class="gmail_quote">
<div>
<div> #include <stdarg.h> </div>
</div>
</div>
</div>
<div class="gmail_extra">
<div class="gmail_quote">
<div>
<div> ^ </div>
</div>
</div>
</div>
<div class="gmail_extra">
<div class="gmail_quote">
<div>
<div> 1 error generated. </div>
</div>
</div>
</div>
<div class="gmail_extra">
<div class="gmail_quote">
<div>
<div> FileCheck error: '-' is empty. </div>
</div>
</div>
</div>
</blockquote>
<div class="gmail_extra">
<div class="gmail_quote">
<div><br>
</div>
<div>> Could you please fix the issue or revert the commit?</div>
<div><br>
</div>
<div>Yes, I am looking at the issues right now. I will fix it soon or revert the change otherwise.</div>
<div>Thanks for the reports.</div>
<div><br>
</div>
<div>Regards,<br>
Petar</div>
</div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>