<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
<div class="">Damn, that’s right. I did a "git clean -xdf” in llvm but not in clang. So I guess it is only about this Makefile slightly more robust.</div>
<div class=""><br class="">
</div>
<div>
<blockquote type="cite" class="">
<div class="">On May 22, 2015, at 4:50 PM, Justin Bogner <<a href="mailto:mail@justinbogner.com" class="">mail@justinbogner.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Mathieu
Baudet <</span><a href="mailto:mathieubaudet@fb.com" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">mathieubaudet@fb.com</a><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">>
writes:</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
Hi,<br class="">
<br class="">
It would appear that I uncovered a very old typo in the Makefile of clang. For<br class="">
some reason it wouldn't break the build until recently (maybe<span class="Apple-converted-space"> </span><a href="https://urldefense.proofpoint.com/v1/url?u=https://llvm.org/&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=DySJRSwIPwJgrlWcFuOjhjgW2TvEV7mDN%2BhK5RWHkOA%3D%0A&m=6Uk7mqELOepnmwTUZPn4pPBZ5MWWqnsfC34W05M5p0o%3D%0A&s=5af656f21e5d4a4b7c1bee0b3d6cc9372457dfa1230c8830fdd6ac20bab2cc64" class="">https://urldefense.proofpoint.com/v1/url?u=https://llvm.org/&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=DySJRSwIPwJgrlWcFuOjhjgW2TvEV7mDN%2BhK5RWHkOA%3D%0A&m=6Uk7mqELOepnmwTUZPn4pPBZ5MWWqnsfC34W05M5p0o%3D%0A&s=5af656f21e5d4a4b7c1bee0b3d6cc9372457dfa1230c8830fdd6ac20bab2cc64</a><br class="">
/svn/llvm-project/cfe/trunk@224924 but I haven’t checked).<br class="">
<br class="">
See the patch in attachment and the test plan below.<br class="">
<br class="">
Best,<br class="">
Mathieu<br class="">
<br class="">
----Test plan——<br class="">
1) before the patch<br class="">
<br class="">
(a) Building with make fails for me<br class="">
<br class="">
Under Mac OS 10.10.3 (Xcode 6.2), with llvm, clang, compiler-rt, and libcxx<br class="">
checked out from recent git hashes, the following steps fail:<br class="">
mkdir llvm-release<br class="">
cd llvm-release<br class="">
../llvm/configure --enable-libcpp --enable-cxx11 --disable-assertions<br class="">
--enable-optimized --disable-bindings<br class="">
make -j 8<br class="">
<br class="">
/Users/mathieubaudet/git/llvm/tools/clang/lib/Frontend/<br class="">
CompilerInvocation.cpp:1046:33: error: unknown type name 'CLANG_LIBDIR_SUFFIX'<br class="">
StringRef ClangLibdirSuffix(CLANG_LIBDIR_SUFFIX);<br class="">
<br class="">
The reason is that "tools/clang/include/clang/Config/config.h" (which defines<br class="">
CLANG_LIBDIR_SUFFIX) is screened by "../llvm/tools/clang/include/clang/Config/<br class="">
config.h" (which does not).<br class="">
</blockquote>
<br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Why
is there a config.h in ../llvm/tools/clang/include/clang/Config/config.h?</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">That
directory should only contain config.h.in and config.h.cmake. I</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">think
that there's something wrong with your checkout.</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
(b) From llvm-release, "make -C tools/clang/lib/Frontend printvars” gives:<br class="">
<br class="">
llvm[0]: Compile.CXX : clang++ -I/Users/mathieubaudet/git/llvm-release/<br class="">
include -I/Users/mathieubaudet/git/llvm-release/tools/clang/lib/Frontend -I/<br class="">
Users/mathieubaudet/git/llvm/include -I/Users/mathieubaudet/git/llvm/tools/<br class="">
clang/lib/Frontend -DNDEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS<br class="">
-D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/Users/mathieubaudet/git/llvm/<br class="">
tools/clang/lib/Frontend/../../include -I/Users/mathieubaudet/git/llvm-release<br class="">
/tools/clang/lib/Frontend/../../include -O3 -stdlib=libc++ -std=c++11<br class="">
-fvisibility-inlines-hidden -fno-exceptions -fno-rtti -fno-common -Wcast-qual<br class="">
-fno-strict-aliasing -m64 -pedantic -Wno-long-long -Wall -W<br class="">
-Wno-unused-parameter -Wwrite-strings -Wcovered-switch-default<br class="">
-Wno-uninitialized -Wno-missing-field-initializers -Wno-comment -c<br class="">
<br class="">
2) after the patch<br class="">
<br class="">
(a) Building with make (same steps, from an empty release dir) succeeds.<br class="">
<br class="">
(b) From llvm-release, "make -C tools/clang/lib/Frontend printvars” gives:<br class="">
<br class="">
llvm[0]: Compile.CXX : clang++ -I/Users/mathieubaudet/git/llvm-release/<br class="">
include -I/Users/mathieubaudet/git/llvm-release/tools/clang/lib/Frontend -I/<br class="">
Users/mathieubaudet/git/llvm/include -I/Users/mathieubaudet/git/llvm/tools/<br class="">
clang/lib/Frontend -DNDEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS<br class="">
-D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/Users/mathieubaudet/git/<br class="">
llvm-release/tools/clang/lib/Frontend/../../include -I/Users/mathieubaudet/git<br class="">
/llvm/tools/clang/lib/Frontend/../../include -O3 -stdlib=libc++ -std=c++11<br class="">
-fvisibility-inlines-hidden -fno-exceptions -fno-rtti -fno-common -Wcast-qual<br class="">
-fno-strict-aliasing -m64 -pedantic -Wno-long-long -Wall -W<br class="">
-Wno-unused-parameter -Wwrite-strings -Wcovered-switch-default<br class="">
-Wno-uninitialized -Wno-missing-field-initializers -Wno-comment -c<br class="">
<br class="">
<br class="">
diff --git a/Makefile b/Makefile<br class="">
index bbc521f..4e70814 100644<br class="">
--- a/Makefile<br class="">
+++ b/Makefile<br class="">
@@ -52,7 +52,7 @@ ifneq ($(ENABLE_DOCS),1)<br class="">
endif<br class="">
<br class="">
# Set common Clang build flags.<br class="">
-CPP.Flags += -I$(PROJ_SRC_DIR)/$(CLANG_LEVEL)/include -I$(PROJ_OBJ_DIR)/$(CLANG_LEVEL)/include<br class="">
+CPP.Flags += -I$(PROJ_OBJ_DIR)/$(CLANG_LEVEL)/include -I$(PROJ_SRC_DIR)/$(CLANG_LEVEL)/include<br class="">
ifdef CLANG_VENDOR<br class="">
CPP.Flags += -DCLANG_VENDOR='"$(CLANG_VENDOR) "'<br class="">
endif<br class="">
_______________________________________________<br class="">
cfe-commits mailing list<br class="">
<a href="mailto:cfe-commits@cs.uiuc.edu" class="">cfe-commits@cs.uiuc.edu</a><br class="">
<a href="https://urldefense.proofpoint.com/v1/url?u=http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=DySJRSwIPwJgrlWcFuOjhjgW2TvEV7mDN%2BhK5RWHkOA%3D%0A&m=6Uk7mqELOepnmwTUZPn4pPBZ5MWWqnsfC34W05M5p0o%3D%0A&s=a93eb8ca76932741ece069faaa57e2dc492a491fb481d62d37b8f54dbe9cf0bd" class="">https://urldefense.proofpoint.com/v1/url?u=http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=DySJRSwIPwJgrlWcFuOjhjgW2TvEV7mDN%2BhK5RWHkOA%3D%0A&m=6Uk7mqELOepnmwTUZPn4pPBZ5MWWqnsfC34W05M5p0o%3D%0A&s=a93eb8ca76932741ece069faaa57e2dc492a491fb481d62d37b8f54dbe9cf0bd</a></blockquote>
</div>
</blockquote>
</div>
<br class="">
</body>
</html>