<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META http-equiv=Content-Type content="text/html; charset=utf-8">
<META content="MSHTML 6.00.2900.6400" name=GENERATOR>
<STYLE></STYLE>
</HEAD>
<BODY bgColor=#ffffff>
<DIV><FONT size=2>Great, thanks. This patch should probably also be marked
for inclusion in the next releases of the 3.5 and 3.6 lines, but I don't know
who is in charge of that.</FONT></DIV>
<DIV><FONT size=2></FONT> </DIV>
<BLOCKQUOTE dir=ltr
style="PADDING-RIGHT: 0px; PADDING-LEFT: 5px; MARGIN-LEFT: 5px; BORDER-LEFT: #000000 2px solid; MARGIN-RIGHT: 0px">
<DIV style="FONT: 10pt arial">----- Original Message ----- </DIV>
<DIV
style="BACKGROUND: #e4e4e4; FONT: 10pt arial; font-color: black"><B>From:</B>
<A title=rnk@google.com href="mailto:rnk@google.com">Reid Kleckner</A> </DIV>
<DIV style="FONT: 10pt arial"><B>To:</B> <A title=andyg1001@hotmail.co.uk
href="mailto:andyg1001@hotmail.co.uk">Andy Gibbs</A> </DIV>
<DIV style="FONT: 10pt arial"><B>Cc:</B> <A title=reid@kleckner.net
href="mailto:reid@kleckner.net">Reid Kleckner</A> ; <A
title=cfe-commits@cs.uiuc.edu
href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits cfe</A> </DIV>
<DIV style="FONT: 10pt arial"><B>Sent:</B> Monday, May 18, 2015 8:08 PM</DIV>
<DIV style="FONT: 10pt arial"><B>Subject:</B> Re: Fw: [PATCH] Fix invalid code
generation (regression) in pass-by-value on PPC32</DIV>
<DIV><BR></DIV>
<DIV dir=ltr>
<DIV class=gmail_extra>
<DIV class=gmail_quote>On Sun, May 17, 2015 at 1:26 PM, Andy Gibbs <SPAN
dir=ltr><<A href="mailto:andyg1001@hotmail.co.uk"
target=_blank>andyg1001@hotmail.co.uk</A>></SPAN> wrote:<BR>
<BLOCKQUOTE class=gmail_quote
style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid">Reid,<BR><BR>I'm
forwarding this onto you since you are the original committer for
r208733<BR>which I wish to partially revert. The patch is attached and
full(er) details<BR>can be found at the bug report (link below). Sorry
for sending it to two<BR>email addresses, but I don't know which is your
active one.<BR><BR>I think you simply factored out code block too many,
where (if I understand<BR>your intentions correctly) you were factoring out
the common code for<BR>*ABI*::classifyReturnType but unintentionally
included<BR>DefaultABIInfo::classifyArgumentType, breaking ppc32 code
generation.<BR><BR>Please can you review my patch to be sure I haven't done
anything stupid<BR>before I commit it.<BR></BLOCKQUOTE>
<DIV><BR></DIV>
<DIV>Yeah, it looks like the refactor went awry. I'm concerned that PPC32 is
relying on DefaultABIInfo and that no test caught this. I'll go ahead and
apply that, thanks for the
patch!</DIV></DIV></DIV></DIV></BLOCKQUOTE></BODY></HTML>