<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 14 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-GB link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Hi Gabor, Renato<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Gabor – have you had a chance to look into why this patch regressed the bots? <o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Renato – Can you remember which bots had problems? Do you have any links for the failures that could help us?<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Ta<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Rich<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><div style='border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt'><div><div><p class=MsoNormal>Author: rengolin<br>Date: Fri May 8 10:44:36 2015<br>New Revision: 236869<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=236869&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=236869&view=rev</a><br>Log:<br>Revert "Allow case-insensitive values for -mcpu for ARM and AArch64"<br><br>This reverts commit r236859, as it broke multiple builds. I'll investigate<br>and reapply when safe.<br><br>Modified:<br> cfe/trunk/lib/Driver/ToolChains.cpp<br> cfe/trunk/lib/Driver/Tools.cpp<br> cfe/trunk/test/Driver/aarch64-cpus.c<br> cfe/trunk/test/Driver/arm-cortex-cpus.c<br><br>Modified: cfe/trunk/lib/Driver/ToolChains.cpp<br>URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.cpp?rev=236869&r1=236868&r2=236869&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.cpp?rev=236869&r1=236868&r2=236869&view=diff</a><br>==============================================================================<br>--- cfe/trunk/lib/Driver/ToolChains.cpp (original)<br>+++ cfe/trunk/lib/Driver/ToolChains.cpp Fri May 8 10:44:36 2015<br>@@ -126,7 +126,7 @@ static const char *GetArmArchForMArch(St<br> }<br><br> static const char *GetArmArchForMCpu(StringRef Value) {<br>- return llvm::StringSwitch<const char *>(Value.lower())<br>+ return llvm::StringSwitch<const char *>(Value)<br> .Cases("arm9e", "arm946e-s", "arm966e-s", "arm968e-s", "arm926ej-s","armv5")<br> .Cases("arm10e", "arm10tdmi", "armv5")<br> .Cases("arm1020t", "arm1020e", "arm1022e", "arm1026ej-s", "armv5")<br><br>Modified: cfe/trunk/lib/Driver/Tools.cpp<br>URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=236869&r1=236868&r2=236869&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=236869&r1=236868&r2=236869&view=diff</a><br>==============================================================================<br>--- cfe/trunk/lib/Driver/Tools.cpp (original)<br>+++ cfe/trunk/lib/Driver/Tools.cpp Fri May 8 10:44:36 2015<br>@@ -902,7 +902,7 @@ static std::string getAArch64TargetCPU(c<br> if ((A = Args.getLastArg(options::OPT_mtune_EQ))) {<br> CPU = A->getValue();<br> } else if ((A = Args.getLastArg(options::OPT_mcpu_EQ))) {<br>- StringRef Mcpu = StringRef(A->getValue()).lower();<br>+ StringRef Mcpu = A->getValue();<br> CPU = Mcpu.split("+").first;<br> }<br><br>@@ -1795,7 +1795,6 @@ static bool DecodeAArch64Features(const<br> // decode CPU and feature.<br> static bool DecodeAArch64Mcpu(const Driver &D, StringRef Mcpu, StringRef &CPU,<br> std::vector<const char *> &Features) {<br>- Mcpu = Mcpu.lower();<br> std::pair<StringRef, StringRef> Split = Mcpu.split("+");<br> CPU = Split.first;<br> if (CPU == "cyclone" || CPU == "cortex-a53" || CPU == "cortex-a57" || CPU == "cortex-a72") {<br>@@ -5642,7 +5641,7 @@ StringRef arm::getARMTargetCPU(const Arg<br> // FIXME: Warn on inconsistent use of -mcpu and -march.<br> // If we have -mcpu=, use that.<br> if (Arg *A = Args.getLastArg(options::OPT_mcpu_EQ)) {<br>- StringRef MCPU = StringRef(A->getValue()).lower();<br>+ StringRef MCPU = A->getValue();<br> // Handle -mcpu=native.<br> if (MCPU == "native")<br> return llvm::sys::getHostCPUName();<br>@@ -7510,7 +7509,7 @@ void gnutools::Assemble::ConstructJob(Co<br> // march from being picked in the absence of a cpu flag.<br> Arg *A;<br> if ((A = Args.getLastArg(options::OPT_mcpu_EQ)) &&<br>- StringRef(A->getValue()).lower() == "krait")<br>+ StringRef(A->getValue()) == "krait")<br> CmdArgs.push_back("-march=armv7-a");<br> else<br> Args.AddLastArg(CmdArgs, options::OPT_mcpu_EQ);<br><br>Modified: cfe/trunk/test/Driver/aarch64-cpus.c<br>URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/aarch64-cpus.c?rev=236869&r1=236868&r2=236869&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/aarch64-cpus.c?rev=236869&r1=236868&r2=236869&view=diff</a><br>==============================================================================<br>--- cfe/trunk/test/Driver/aarch64-cpus.c (original)<br>+++ cfe/trunk/test/Driver/aarch64-cpus.c Fri May 8 10:44:36 2015<br>@@ -111,15 +111,3 @@<br> // RUN: %clang -target aarch64_be -mbig-endian -march=armv8.1-a -### -c %s 2>&1 | FileCheck -check-prefix=GENERICV81A-BE %s<br> // GENERICV81A-BE: "-cc1"{{.*}} "-triple" "aarch64_be{{.*}}" "-target-cpu" "generic" "-target-feature" "+neon" "-target-feature" "+v8.1a"<br><br>-// ================== Check whether -mcpu accepts mixed-case values.<br>-// RUN: %clang -target aarch64 -mcpu=Cortex-a53 -### -c %s 2>&1 | FileCheck -check-prefix=CASE-INSENSITIVE-CA53 %s<br>-// CASE-INSENSITIVE-CA53: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-cpu" "cortex-a53"<br>-<br>-// RUN: %clang -target arm64 -mcpu=cortex-A53 -### -c %s 2>&1 | FileCheck -check-prefix=CASE-INSENSITIVE-ARM64-CA53 %s<br>-// CASE-INSENSITIVE-ARM64-CA53: "-cc1"{{.*}} "-triple" "arm64{{.*}}" "-target-cpu" "cortex-a53"<br>-<br>-// RUN: %clang -target aarch64 -mcpu=CORTEX-A57 -### -c %s 2>&1 | FileCheck -check-prefix=CASE-INSENSITIVE-CA57 %s<br>-// CASE-INSENSITIVE-CA57: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-cpu" "cortex-a57"<br>-<br>-// RUN: %clang -target arm64 -mcpu=Cortex-A57 -### -c %s 2>&1 | FileCheck -check-prefix=CASE-INSENSITIVE-ARM64-CA57 %s<br>-// CASE-INSENSITIVE-ARM64-CA57: "-cc1"{{.*}} "-triple" "arm64{{.*}}" "-target-cpu" "cortex-a57"<br><br>Modified: cfe/trunk/test/Driver/arm-cortex-cpus.c<br>URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/arm-cortex-cpus.c?rev=236869&r1=236868&r2=236869&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/arm-cortex-cpus.c?rev=236869&r1=236868&r2=236869&view=diff</a><br>==============================================================================<br>--- cfe/trunk/test/Driver/arm-cortex-cpus.c (original)<br>+++ cfe/trunk/test/Driver/arm-cortex-cpus.c Fri May 8 10:44:36 2015<br>@@ -351,13 +351,3 @@<br> // RUN: %clang -target arm -mcpu=cortex-a57 -mbig-endian -mthumb -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-BE-CPUV8A-THUMB %s<br> // RUN: %clang -target arm -mcpu=cortex-a72 -mbig-endian -mthumb -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-BE-CPUV8A-THUMB %s<br> // CHECK-BE-CPUV8A-THUMB: "-cc1"{{.*}} "-triple" "thumbebv8-{{.*}}<br>-<br>-// ================== Check whether -mcpu accepts mixed-case values.<br>-// RUN: %clang -target arm-linux-gnueabi -mcpu=Cortex-a5 -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-CASE-INSENSITIVE-CPUV7A %s<br>-// RUN: %clang -target arm-linux-gnueabi -mcpu=cortex-A7 -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-CASE-INSENSITIVE-CPUV7A %s<br>-// RUN: %clang -target arm-linux-gnueabi -mcpu=CORTEX-a8 -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-CASE-INSENSITIVE-CPUV7A %s<br>-// RUN: %clang -target arm-linux-gnueabi -mcpu=Cortex-A9 -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-CASE-INSENSITIVE-CPUV7A %s<br>-// RUN: %clang -target arm-linux-gnueabi -mcpu=corteX-A12 -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-CASE-INSENSITIVE-CPUV7A %s<br>-// RUN: %clang -target arm-linux-gnueabi -mcpu=CorteX-a15 -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-CASE-INSENSITIVE-CPUV7A %s<br>-// RUN: %clang -target arm-linux-gnueabi -mcpu=CorteX-A17 -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-CASE-INSENSITIVE-CPUV7A %s<br>-// CHECK-CASE-INSENSITIVE-CPUV7A: "-cc1"{{.*}} "-triple" "armv7-{{.*}}<br><br><br>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><o:p></o:p></p></div><p class=MsoNormal><o:p> </o:p></p></div></div></div></body></html>