<div dir="rtl"><div dir="ltr">Yep, the remap test is the result of having two entries with different slashes in the FileManager. I looked into this some time ago.</div><div dir="ltr"><br></div><div dir="ltr"><br></div></div><div class="gmail_extra"><div dir="ltr"><br><div class="gmail_quote">2015-05-08 12:53 GMT+03:00 Nikola Smiljanic <span dir="ltr"><<a href="mailto:popizdeh@gmail.com" target="_blank">popizdeh@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 .8ex;border-left:1px #ccc solid;border-right:1px #ccc solid;padding-left:1ex;padding-right:1ex">Well only 4 tests failed, and three of those are not real failures, they're matching slashes. The fourth one is real failure, -remap-file seems to break with my change, I didn't have time to investigate.</blockquote></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, May 8, 2015 at 7:30 PM, Yaron Keren <span dir="ltr"><<a href="mailto:yaron.keren@gmail.com" target="_blank">yaron.keren@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="rtl"><div dir="ltr">I think this can't be fixed until FileManager is case- and slash- insensitive on Windows, matching the OS behaviour. See <a href="http://llvm.org/pr17993" target="_blank">http://llvm.org/pr17993</a></div><div dir="ltr"><br></div></div><div class="gmail_extra"><br><div class="gmail_quote"><div dir="ltr">2015-05-08 9:02 GMT+03:00 Nikola Smiljanic <span dir="ltr"><<a href="mailto:popizdeh@gmail.com" target="_blank">popizdeh@gmail.com</a>></span>:</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: nikola<br>
Date: Fri May  8 01:02:37 2015<br>
New Revision: 236806<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=236806&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=236806&view=rev</a><br>
Log:<br>
Revert "Fix path separator issue on Windows."<br>
<br>
This reverts commit 9242ff16b0460b488691fd70b42a2bf81a531e3a.<br>
<br>
Modified:<br>
    cfe/trunk/lib/Lex/HeaderSearch.cpp<br>
<br>
Modified: cfe/trunk/lib/Lex/HeaderSearch.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Lex/HeaderSearch.cpp?rev=236806&r1=236805&r2=236806&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Lex/HeaderSearch.cpp?rev=236806&r1=236805&r2=236806&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Lex/HeaderSearch.cpp (original)<br>
+++ cfe/trunk/lib/Lex/HeaderSearch.cpp Fri May  8 01:02:37 2015<br>
@@ -614,8 +614,10 @@ const FileEntry *HeaderSearch::LookupFil<br>
       const FileEntry *Includer = IncluderAndDir.first;<br>
<br>
       // Concatenate the requested file onto the directory.<br>
+      // FIXME: Portability.  Filename concatenation should be in sys::Path.<br>
       TmpDir = IncluderAndDir.second->getName();<br>
-      llvm::sys::path::append(TmpDir, Filename);<br>
+      TmpDir.push_back('/');<br>
+      TmpDir.append(Filename.begin(), Filename.end());<br>
<br>
       // FIXME: We don't cache the result of getFileInfo across the call to<br>
       // getFileAndSuggestModule, because it's a reference to an element of<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>
</blockquote></div><br></div>
</div></div></div></div>