<p dir="ltr">LGTM. Was just waiting on Nick's ok. <br>
</p>
<p dir="ltr"></p>
<p dir="ltr">On Sat, May 2, 2015, 10:30 PM Nick Lewycky <<a href="mailto:nicholas@mxc.ca">nicholas@mxc.ca</a>> wrote:</p>
<blockquote><p dir="ltr">Jonathan Roelofs wrote:<br>
> Hi echristo, nlewycky,<br>
><br>
> (CC-ing cfe-commits even though this is an LLVM patch... it affects both projects)<br>
><br>
> This is a followup from: <a href="http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20150323/268067.html">http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20150323/268067.html</a><br>
><br>
> Upgrade instructions:<br>
> ```<br>
> $ mv llvm/include/llvm/Config/config.h ./config.h.BACKUP<br>
><br>
> # copy the configure line from line 7 of llvm/config.log (for example: `$ ./configure --no-create --no-recursion`<br>
><br>
> $ mkdir build<br>
> $ cd build<br>
><br>
> # run the configure line, but this time with '../llvm' at the beginning:<br>
><br>
> $ ../llvm/configure --no-create --no-recursion<br>
> ```</p>
<p dir="ltr">Thanks for doing this! The patch LGTM. Eric?</p>
</blockquote>
<p dir="ltr"></p>
<blockquote><p dir="ltr"></p>
<p dir="ltr">><br>
> <a href="http://reviews.llvm.org/D9351">http://reviews.llvm.org/D9351</a><br>
><br>
> Files:<br>
> <a href="http://Makefile.config.in">Makefile.config.in</a><br>
> autoconf/<a href="http://configure.ac">configure.ac</a><br>
> configure<br>
><br>
> Index: <a href="http://Makefile.config.in">Makefile.config.in</a><br>
> ===================================================================<br>
> --- <a href="http://Makefile.config.in">Makefile.config.in</a><br>
> +++ <a href="http://Makefile.config.in">Makefile.config.in</a><br>
> @@ -58,6 +58,22 @@<br>
> PROJ_SRC_ROOT := $(LLVM_SRC_ROOT)<br>
> PROJ_SRC_DIR := $(LLVM_SRC_ROOT)$(patsubst $(PROJ_OBJ_ROOT)%,%,$(PROJ_OBJ_DIR))<br>
><br>
> +# FIXME: This is temporary during the grace period where in-source builds are<br>
> +# deprecated. Convert to a hard error when that period is up.<br>
> +#<br>
> +# See: <a href="http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20150323/268067.html">http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20150323/268067.html</a><br>
> +ifeq ($(LLVM_SRC_ROOT), $(LLVM_OBJ_ROOT))<br>
> + $(warning ######################################################################################)<br>
> + $(warning # #)<br>
> + $(warning # WARNING #)<br>
> + $(warning # #)<br>
> + $(warning # In-source builds are deprecated. #)<br>
> + $(warning # #)<br>
> + $(warning # Please configure from a separate build directory! #)<br>
> + $(warning # #)<br>
> + $(warning ######################################################################################)<br>
> +endif<br>
> +<br>
> ifneq ($(CLANG_SRC_ROOT),)<br>
> CLANG_SRC_ROOT:= $(call realpath, $(CLANG_SRC_ROOT))<br>
> PROJ_SRC_DIR := $(patsubst $(LLVM_SRC_ROOT)/tools/clang%,$(CLANG_SRC_ROOT)%,$(PROJ_SRC_DIR))<br>
> Index: autoconf/<a href="http://configure.ac">configure.ac</a><br>
> ===================================================================<br>
> --- autoconf/<a href="http://configure.ac">configure.ac</a><br>
> +++ autoconf/<a href="http://configure.ac">configure.ac</a><br>
> @@ -73,6 +73,19 @@<br>
> fi<br>
> fi<br>
><br>
> +dnl Quit if it is an in-source build<br>
> +if test ${srcdir} == "." ; then<br>
> + AC_MSG_WARN([**************************************************************************************])<br>
> + AC_MSG_WARN([* *])<br>
> + AC_MSG_WARN([* WARNING *])<br>
> + AC_MSG_WARN([* *])<br>
> + AC_MSG_WARN([* In-source builds are deprecated. *])<br>
> + AC_MSG_WARN([* *])<br>
> + AC_MSG_WARN([* Please configure from a separate build directory! *])<br>
> + AC_MSG_WARN([* *])<br>
> + AC_MSG_WARN([**************************************************************************************])<br>
> +fi<br>
> +<br>
> dnl Default to empty (i.e. assigning the null string to) CFLAGS and CXXFLAGS,<br>
> dnl instead of the autoconf default (for example, '-g -O2' for CC=gcc).<br>
> : ${CFLAGS=}<br>
> Index: configure<br>
> ===================================================================<br>
> --- configure<br>
> +++ configure<br>
> @@ -2030,6 +2030,27 @@<br>
> fi<br>
> fi<br>
><br>
> +if test ${srcdir} == "." ; then<br>
> + { echo "$as_me:$LINENO: WARNING: **************************************************************************************">&5<br>
> +echo "$as_me: WARNING: **************************************************************************************">&2;}<br>
> + { echo "$as_me:$LINENO: WARNING: * *">&5<br>
> +echo "$as_me: WARNING: * *">&2;}<br>
> + { echo "$as_me:$LINENO: WARNING: * WARNING *">&5<br>
> +echo "$as_me: WARNING: * WARNING *">&2;}<br>
> + { echo "$as_me:$LINENO: WARNING: * *">&5<br>
> +echo "$as_me: WARNING: * *">&2;}<br>
> + { echo "$as_me:$LINENO: WARNING: * In-source builds are deprecated. *">&5<br>
> +echo "$as_me: WARNING: * In-source builds are deprecated. *">&2;}<br>
> + { echo "$as_me:$LINENO: WARNING: * *">&5<br>
> +echo "$as_me: WARNING: * *">&2;}<br>
> + { echo "$as_me:$LINENO: WARNING: * Please configure from a separate build directory! *">&5<br>
> +echo "$as_me: WARNING: * Please configure from a separate build directory! *">&2;}<br>
> + { echo "$as_me:$LINENO: WARNING: * *">&5<br>
> +echo "$as_me: WARNING: * *">&2;}<br>
> + { echo "$as_me:$LINENO: WARNING: **************************************************************************************">&5<br>
> +echo "$as_me: WARNING: **************************************************************************************">&2;}<br>
> +fi<br>
> +<br>
> : ${CFLAGS=}<br>
> : ${CXXFLAGS=}<br>
><br>
> EMAIL PREFERENCES<br>
> <a href="http://reviews.llvm.org/settings/panel/emailpreferences/">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
><br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</p>
</blockquote>
<p dir="ltr"><br>
</p>