<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Sorry! Fixed in r236051. <div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Apr 28, 2015, at 3:08 PM, Justin Bogner <<a href="mailto:mail@justinbogner.com" class="">mail@justinbogner.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: 14px; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Steven Wu <</span><a href="mailto:stevenwu@apple.com" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: 14px; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">stevenwu@apple.com</a><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: 14px; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">> writes:</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: 14px; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: 14px; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">Author: steven_wu<br class="">Date: Tue Apr 28 16:49:09 2015<br class="">New Revision: 236044<br class=""><br class="">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=236044&view=rev" class="">http://llvm.org/viewvc/llvm-project?rev=236044&view=rev</a><br class="">Log:<br class="">Fix -fno-gnu-inline-asm doesn't catch file scope asm<br class=""><br class="">Summary:<br class="">FileScopeAsm should be treated the same as funcion level inline asm.<br class="">-fno-gnu-inline-asm should trigger an error if file scope asm is used.<br class="">I missed this case from r226340. This should not affect ms-extension<br class="">because it is not allowed in the file scope.<br class=""><br class="">Reviewers: bob.wilson, rnk<br class=""><br class="">Reviewed By: rnk<br class=""><br class="">Subscribers: cfe-commits<br class=""><br class="">Differential Revision: <a href="http://reviews.llvm.org/D9328" class="">http://reviews.llvm.org/D9328</a><br class=""><br class="">Modified:<br class=""> cfe/trunk/lib/Parse/Parser.cpp<br class=""> cfe/trunk/test/Parser/no-gnu-inline-asm.c<br class=""><br class="">Modified: cfe/trunk/lib/Parse/Parser.cpp<br class="">URL:<br class=""><a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Parse/Parser.cpp?rev=236044&r1=236043&r2=236044&view=diff" class="">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Parse/Parser.cpp?rev=236044&r1=236043&r2=236044&view=diff</a><br class="">==============================================================================<br class="">--- cfe/trunk/lib/Parse/Parser.cpp (original)<br class="">+++ cfe/trunk/lib/Parse/Parser.cpp Tue Apr 28 16:49:09 2015<br class="">@@ -1253,6 +1253,10 @@ ExprResult Parser::ParseSimpleAsm(Source<br class=""> assert(Tok.is(tok::kw_asm) && "Not an asm!");<br class=""> SourceLocation Loc = ConsumeToken();<br class=""><br class="">+ // Check if GNU-styple InlineAsm is disabled.<br class=""></blockquote><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: 14px; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class=""> ^</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: 14px; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: 14px; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Typo.</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: 14px; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: 14px; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: 14px; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">+ if (!getLangOpts().GNUAsm)<br class="">+ Diag(Loc, diag::err_gnu_inline_asm_disabled);<br class="">+<br class=""> if (<a href="http://Tok.is" class="">Tok.is</a>(tok::kw_volatile)) {<br class=""> // Remove from the end of 'asm' to the end of 'volatile'.<br class=""> SourceRange RemovalRange(PP.getLocForEndOfToken(Loc),<br class=""><br class="">Modified: cfe/trunk/test/Parser/no-gnu-inline-asm.c<br class="">URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Parser/no-gnu-inline-asm.c?rev=236044&r1=236043&r2=236044&view=diff" class="">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Parser/no-gnu-inline-asm.c?rev=236044&r1=236043&r2=236044&view=diff</a><br class="">==============================================================================<br class="">--- cfe/trunk/test/Parser/no-gnu-inline-asm.c (original)<br class="">+++ cfe/trunk/test/Parser/no-gnu-inline-asm.c Tue Apr 28 16:49:09 2015<br class="">@@ -1,5 +1,6 @@<br class="">// RUN: %clang_cc1 %s -triple i686-apple-darwin -verify -fsyntax-only -fno-gnu-inline-asm<br class=""><br class="">+asm ("INST r1, 0"); // expected-error {{GNU-style inline assembly is disabled}}<br class="">void f (void) {<br class=""> long long foo = 0, bar;<br class=""> asm volatile("INST %0, %1" : "=r"(foo) : "r"(bar)); // expected-error {{GNU-style inline assembly is disabled}}<br class=""><br class=""><br class="">_______________________________________________<br class="">cfe-commits mailing list<br class=""><a href="mailto:cfe-commits@cs.uiuc.edu" class="">cfe-commits@cs.uiuc.edu</a><br class="">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</blockquote></div></blockquote></div><br class=""></div></body></html>