<div dir="ltr"><div>Hi Saleem,<br><br></div>Please reconsider this change.  IMHO<span></span>, the correct solution is to avoid the extension instead of marking LLVM-libunwind as mandatory.  Thanks.<br></div><div dir="ltr"><br></div><div dir="ltr">Logan</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 28, 2015 at 2:19 AM, Saleem Abdulrasool <span dir="ltr"><<a href="javascript:_e(%7B%7D,'cvml','compnerd@compnerd.org');" target="_blank">compnerd@compnerd.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: compnerd<br>
Date: Mon Apr 27 13:19:33 2015<br>
New Revision: 235904<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=235904&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=235904&view=rev</a><br>
Log:<br>
libc++abi: enable LLVM unwinder by default for ARM<br>
<br>
libc++abi uses EHABI extensions, which are only part of the LLVM unwinder.  When<br>
targeting ARM by default, enable the use of the LLVM unwinder.  Hopefully this<br>
will fix the ARM native bot<br>
<br>
Modified:<br>
    libcxxabi/trunk/CMakeLists.txt<br>
<br>
Modified: libcxxabi/trunk/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/CMakeLists.txt?rev=235904&r1=235903&r2=235904&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/CMakeLists.txt?rev=235904&r1=235903&r2=235904&view=diff</a><br>
==============================================================================<br>
--- libcxxabi/trunk/CMakeLists.txt (original)<br>
+++ libcxxabi/trunk/CMakeLists.txt Mon Apr 27 13:19:33 2015<br>
@@ -114,7 +114,12 @@ endif()<br>
 option(LIBCXXABI_ENABLE_ASSERTIONS "Enable assertions independent of build mode." ON)<br>
 option(LIBCXXABI_ENABLE_PEDANTIC "Compile with pedantic enabled." ON)<br>
 option(LIBCXXABI_ENABLE_WERROR "Fail and stop if a warning is triggered." OFF)<br>
-option(LIBCXXABI_USE_LLVM_UNWINDER "Build and use the LLVM unwinder." OFF)<br>
+set(LIBCXXABI_USE_LLVM_UNWINDER_DEFAULT OFF)<br>
+if (${LLVM_NATIVE_ARCH} MATCHES arm)<br>
+  set(LIBCXXABI_USE_LLVM_UNWINDER_DEFAULT ON)<br>
+endif ()<br>
+option(LIBCXXABI_USE_LLVM_UNWINDER "Build and use the LLVM unwinder."<br>
+       ${LIBCXXABI_USE_LLVM_UNWINDER_DEFAULT})<br>
 option(LIBCXXABI_ENABLE_THREADS "Build with threads enabled" ON)<br>
 set(LIBCXXABI_GCC_TOOLCHAIN "" CACHE STRING "GCC toolchain for cross compiling.")<br>
 set(LIBCXXABI_SYSROOT "" CACHE STRING "Sysroot for cross compiling.")<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="javascript:_e(%7B%7D,'cvml','cfe-commits@cs.uiuc.edu');" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>