<div dir="ltr">Tom, would you mind putting the review on <a href="http://reviews.llvm.org/">http://reviews.llvm.org/</a> (that way I'll get to it faster). You can follow the steps here: <a href="http://llvm.org/docs/Phabricator.html">http://llvm.org/docs/Phabricator.html</a>. Don't forget to cc cfe-commits on the patch as subscriber.<br></div><br><div class="gmail_quote">On Sat, Apr 18, 2015 at 4:45 AM Tom Honermann <<a href="mailto:thonermann@coverity.com">thonermann@coverity.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thanks all for following up on this.<br>
<br>
I had added comments to the BZ detailing the issue and the patches<br>
attached. If those comments are insufficient to explain the issue, how<br>
I addressed it, or details of the unit test, I'll be happy to add more<br>
detail.<br>
<br>
<a href="https://llvm.org/bugs/show_bug.cgi?id=23175" target="_blank">https://llvm.org/bugs/show_bug.cgi?id=23175</a><br>
<br>
Tom.<br>
<br>
On 04/17/2015 09:42 PM, Nikola Smiljanic wrote:<br>
> Two patches are attached in the bug report, fix and unittest. The code<br>
> is tooling related so you seem like a good choice :) I had a look but am<br>
> clueless when it comes to this part of clang.<br>
><br>
> On Sat, Apr 18, 2015 at 11:40 AM, Manuel Klimek <<a href="mailto:klimek@google.com" target="_blank">klimek@google.com</a><br>
> <mailto:<a href="mailto:klimek@google.com" target="_blank">klimek@google.com</a>>> wrote:<br>
><br>
> What do I need to do here?<br>
><br>
> On Fri, Apr 17, 2015 at 6:34 PM Nikola Smiljanic <<a href="mailto:popizdeh@gmail.com" target="_blank">popizdeh@gmail.com</a><br>
> <mailto:<a href="mailto:popizdeh@gmail.com" target="_blank">popizdeh@gmail.com</a>>> wrote:<br>
><br>
> Adding Klimek to help move this along :)<br>
><br>
> On Wed, Apr 15, 2015 at 5:34 AM, Tom Honermann<br>
> <<a href="mailto:thonermann@coverity.com" target="_blank">thonermann@coverity.com</a> <mailto:<a href="mailto:thonermann@coverity.com" target="_blank">thonermann@coverity.com</a>>> wrote:<br>
><br>
> Removing cfe-dev; CCing cfe-commits and akirtzidis (who svn<br>
> suggests has previously made changes in this area. I'm<br>
> guessing at an email address for akirtzidis).<br>
><br>
> Tom.<br>
><br>
> On 04/14/2015 03:52 AM, Nikola Smiljanic wrote:<br>
><br>
> Please send patches to cfe-commits or use Phabricator,<br>
> they'll just get<br>
> lost in the issue tracker. Make sure you CC someone as well.<br>
><br>
> On Tue, Apr 14, 2015 at 12:02 AM, Tom Honermann<br>
> <<a href="mailto:thonermann@coverity.com" target="_blank">thonermann@coverity.com</a> <mailto:<a href="mailto:thonermann@coverity.com" target="_blank">thonermann@coverity.com</a>><br>
> <mailto:<a href="mailto:thonermann@coverity.com" target="_blank">thonermann@coverity.com</a><br>
> <mailto:<a href="mailto:thonermann@coverity.com" target="_blank">thonermann@coverity.com</a>>>> wrote:<br>
><br>
> Could someone be so kind as to review the patches<br>
> attached to<br>
> PR23175 and, assuming no concerns, commit them?<br>
><br>
> Bug 23175 - Infinite loop iterating Objective-C<br>
> method declarations<br>
> in categories when the AST was deserialized from an<br>
> .ast file<br>
> <a href="https://llvm.org/bugs/show___bug.cgi?id=23175" target="_blank">https://llvm.org/bugs/show___bug.cgi?id=23175</a><br>
> <<a href="https://llvm.org/bugs/show_bug.cgi?id=23175" target="_blank">https://llvm.org/bugs/show_bug.cgi?id=23175</a>><br>
><br>
> Thank you,<br>
> Tom.<br>
> _________________________________________________<br>
> cfe-dev mailing list<br>
> <a href="mailto:cfe-dev@cs.uiuc.edu" target="_blank">cfe-dev@cs.uiuc.edu</a> <mailto:<a href="mailto:cfe-dev@cs.uiuc.edu" target="_blank">cfe-dev@cs.uiuc.edu</a>><br>
> <mailto:<a href="mailto:cfe-dev@cs.uiuc.edu" target="_blank">cfe-dev@cs.uiuc.edu</a> <mailto:<a href="mailto:cfe-dev@cs.uiuc.edu" target="_blank">cfe-dev@cs.uiuc.edu</a>>><br>
> <a href="http://lists.cs.uiuc.edu/__mailman/listinfo/cfe-dev" target="_blank">http://lists.cs.uiuc.edu/__mailman/listinfo/cfe-dev</a><br>
> <<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</a>><br>
><br>
><br>
><br>
><br>
</blockquote></div>