<div dir="ltr"><br><div class="gmail_extra"><div class="gmail_quote">On 17 April 2015 at 06:31, Aaron Ballman <span dir="ltr"><<a href="mailto:aaron@aaronballman.com" target="_blank">aaron@aaronballman.com</a>></span> wrote:<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
I agree with Richard's comments about this being extended to apply to<br>
a list of sanitizers. I wish we would have done that for the<br>
no_sanitize_blah attributes.<br>
<br>
Also, why no C++-style attribute?<br></blockquote><div><br></div><div><div class="gmail_extra" style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br>You mean something like GCC<"no_sanitize_vtpr"> instead? </div></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class="">
</span>I think some more documentation would be nice. People aren't always<br>
familiar with what those vptr checks would look like, or why they<br>
might want to have them removed. What's the benefit to applying this<br>
attribute, how would you decide when it's appropriate to add it, etc.<br></blockquote><div><br></div><div>Would that documentation belong here?</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><br>
<br>
Why is the shell required for this test?<br></blockquote><div><br></div><div>I forgot to delete this when I copied the file from another test. Removed. </div></div><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr">Cheers,<div>Oliver</div></div></div>
</div></div>