<div dir="ltr"><p dir="ltr">Instead of doing this, should we expose the gcc spelling -fno-diagnostic-color? The there would be a single option to disable colors that worked with gcc, clang, and clang-cl.</p>
<div class="gmail_quote">On Apr 11, 2015 5:31 AM, "Hans Wennborg" <<a href="mailto:hans@hanshq.net" target="_blank">hans@hanshq.net</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: hans<br>
Date: Sat Apr 11 07:27:56 2015<br>
New Revision: 234685<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=234685&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=234685&view=rev</a><br>
Log:<br>
clang-cl: support -fno-color-diagnostics (PR23109)<br>
<br>
Patch by Bernard Solomon, tests by me.<br>
<br>
Modified:<br>
    cfe/trunk/include/clang/Driver/Options.td<br>
    cfe/trunk/test/Driver/cl-options.c<br>
<br>
Modified: cfe/trunk/include/clang/Driver/Options.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/Options.td?rev=234685&r1=234684&r2=234685&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/Options.td?rev=234685&r1=234684&r2=234685&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/include/clang/Driver/Options.td (original)<br>
+++ cfe/trunk/include/clang/Driver/Options.td Sat Apr 11 07:27:56 2015<br>
@@ -734,7 +734,8 @@ def fno_math_builtin : Flag<["-"], "fno-<br>
   HelpText<"Disable implicit builtin knowledge of math functions">;<br>
 def fno_caret_diagnostics : Flag<["-"], "fno-caret-diagnostics">, Group<f_Group>,<br>
  Flags<[CC1Option]>;<br>
-def fno_color_diagnostics : Flag<["-"], "fno-color-diagnostics">, Group<f_Group>;<br>
+def fno_color_diagnostics : Flag<["-"], "fno-color-diagnostics">, Group<f_Group>,<br>
+  Flags<[CoreOption, CC1Option]>;<br>
 def fno_diagnostics_color : Flag<["-"], "fno-diagnostics-color">, Group<f_Group>;<br>
 def fno_common : Flag<["-"], "fno-common">, Group<f_Group>, Flags<[CC1Option]>,<br>
     HelpText<"Compile common globals like normal definitions">;<br>
<br>
Modified: cfe/trunk/test/Driver/cl-options.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/cl-options.c?rev=234685&r1=234684&r2=234685&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/cl-options.c?rev=234685&r1=234684&r2=234685&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/Driver/cl-options.c (original)<br>
+++ cfe/trunk/test/Driver/cl-options.c Sat Apr 11 07:27:56 2015<br>
@@ -346,6 +346,8 @@<br>
 // (/Zs is for syntax-only, -Werror makes it fail hard on unknown options)<br>
 // RUN: %clang_cl \<br>
 // RUN:     --driver-mode=cl \<br>
+// RUN:     -fcolor-diagnostics \<br>
+// RUN:     -fno-color-diagnostics \<br>
 // RUN:     -ferror-limit=10 \<br>
 // RUN:     -fmsc-version=1800 \<br>
 // RUN:     -fno-strict-aliasing \<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>
</div>