<div dir="ltr">Thanks!</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Apr 9, 2015 at 11:50 AM, Hans Wennborg <span dir="ltr"><<a href="mailto:hans@chromium.org" target="_blank">hans@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Wed, Apr 1, 2015 at 3:42 PM, Alexey Samsonov <<a href="mailto:vonosmas@gmail.com">vonosmas@gmail.com</a>> wrote:<br>
</span><span class="">> Author: samsonov<br>
> Date: Wed Apr  1 17:42:25 2015<br>
> New Revision: 233860<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=233860&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=233860&view=rev</a><br>
> Log:<br>
> [UBSan] Embed UBSan into ASan runtime (Clang part).<br>
</span>[..]<br>
<span class="">> Modified: cfe/trunk/lib/Driver/ToolChains.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.cpp?rev=233860&r1=233859&r2=233860&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.cpp?rev=233860&r1=233859&r2=233860&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/lib/Driver/ToolChains.cpp (original)<br>
> +++ cfe/trunk/lib/Driver/ToolChains.cpp Wed Apr  1 17:42:25 2015<br>
> @@ -338,6 +338,9 @@ void DarwinClang::AddLinkSanitizerLibArg<br>
>                                      OS + "_dynamic.dylib").str(),<br>
>                      /*AlwaysLink*/ true, /*IsEmbedded*/ false,<br>
>                      /*AddRPath*/ true);<br>
> +  // Add explicit dependcy on -lc++abi, as -lc++ doesn't re-export<br>
> +  // all RTTI-related symbols that UBSan uses.<br>
> +  CmdArgs.push_back("-lc++abi");<br>
<br>
</span>This broke Chromium's ASan build on Darwin, which doesn't use libc++.<br>
I've tried to fix in r234521.<br>
<span class="HOEnZb"><font color="#888888"><br>
 - Hans<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr">Alexey Samsonov<br><a href="mailto:vonosmas@gmail.com" target="_blank">vonosmas@gmail.com</a></div></div>
</div>