<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 05.04.2015 7:16, Anna Zaks wrote:<br>
</div>
<blockquote
cite="mid:CA+=xKSUGDYW3xdkLsnpRMxEavH2Kj4Z5hLndTFcqiD-WFZh13w@mail.gmail.com"
type="cite">
<div dir="ltr">Hi Anton,
<div><br>
</div>
<div>Have you tested the patch on anything but the regression
tests? If yes, what are the results? Did this catch any
issues? Are there any false positives? <span
style="line-height:normal">Since this will be a turned on by
default new warning, I'd like make sure we test on real code
before </span>committing.</div>
</div>
</blockquote>
Ran the checker over LLVM and Ogre codebases, neither
false-positives nor issues found except for one artificially
injected issue. Ok to commit?<br>
<br>
<blockquote
cite="mid:CA+=xKSUGDYW3xdkLsnpRMxEavH2Kj4Z5hLndTFcqiD-WFZh13w@mail.gmail.com"
type="cite">
<div dir="ltr">
<div><br>
</div>
<div>Other than testing, this looks good to me. <span
style="line-height:normal">Thank you!</span></div>
<div>Anna.<br>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Sat, Mar 21, 2015 at 7:19 AM,
Антон Ярцев <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:anton.yartsev@gmail.com" target="_blank">anton.yartsev@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex"><span
class="">.<br>
<br>
<br>
================<br>
Comment at:
lib/StaticAnalyzer/Checkers/MallocChecker.cpp:889<br>
@@ +888,3 @@<br>
+ const RefState *RS =
State->get<RegionState>(Sym);<br>
+ if (!RS || !RS->isAllocated())<br>
+ return State;<br>
----------------<br>
</span><span class="">ayartsev wrote:<br>
> zaks.anna wrote:<br>
> > It should not be possible to have non
allocated symbol here.. Is it? Maybe we should assert?<br>
> Agree, done!<br>
</span>Pardon, currently zero-allocated realloc do not
attach a RefState so it is still early to assert for
now.<br>
<div class="HOEnZb">
<div class="h5"><br>
</div>
</div>
</blockquote>
<div><br>
</div>
<div>Is there a test for this? If not, please add one.</div>
</div>
</div>
</div>
</div>
</blockquote>
Added several realloc() tests with TODO comments.<br>
<br>
<blockquote
cite="mid:CA+=xKSUGDYW3xdkLsnpRMxEavH2Kj4Z5hLndTFcqiD-WFZh13w@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div class="gmail_extra">
<div class="gmail_quote">
<div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb">
<div class="h5">
<a moz-do-not-send="true"
href="http://reviews.llvm.org/D8273"
target="_blank">http://reviews.llvm.org/D8273</a><br>
<br>
EMAIL PREFERENCES<br>
<a moz-do-not-send="true"
href="http://reviews.llvm.org/settings/panel/emailpreferences/"
target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Anton</pre>
</body>
</html>