<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Apr 1, 2015 at 11:28 AM, Jonathan Roelofs <span dir="ltr"><<a href="mailto:jonathan@codesourcery.com" target="_blank">jonathan@codesourcery.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class=""><br>
<br>
On 4/1/15 9:49 AM, Eric Fiselier wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Author: ericwf<br>
Date: Wed Apr  1 10:49:02 2015<br>
New Revision: 233816<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=233816&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=233816&view=rev</a><br>
Log:<br>
Remove statement with no effect inside tests.<br>
<br>
Modified:<br>
     libcxx/trunk/test/std/<u></u>language.support/support.<u></u>dynamic/new.delete/new.delete.<u></u>array/sized_delete_array.pass.<u></u>cpp<br>
     libcxx/trunk/test/std/<u></u>language.support/support.<u></u>dynamic/new.delete/new.delete.<u></u>single/sized_delete.pass.cpp<br>
<br>
Modified: libcxx/trunk/test/std/<u></u>language.support/support.<u></u>dynamic/new.delete/new.delete.<u></u>array/sized_delete_array.pass.<u></u>cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/sized_delete_array.pass.cpp?rev=233816&r1=233815&r2=233816&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/libcxx/trunk/test/std/<u></u>language.support/support.<u></u>dynamic/new.delete/new.delete.<u></u>array/sized_delete_array.pass.<u></u>cpp?rev=233816&r1=233815&r2=<u></u>233816&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- libcxx/trunk/test/std/<u></u>language.support/support.<u></u>dynamic/new.delete/new.delete.<u></u>array/sized_delete_array.pass.<u></u>cpp (original)<br>
+++ libcxx/trunk/test/std/<u></u>language.support/support.<u></u>dynamic/new.delete/new.delete.<u></u>array/sized_delete_array.pass.<u></u>cpp Wed Apr  1 10:49:02 2015<br>
@@ -23,7 +23,6 @@ int delete_nothrow_called = 0;<br>
  void operator delete[](void* p) throw()<br>
  {<br>
      ++delete_called;<br>
-    delete_nothrow_called;<br>
</blockquote></span>
Maybe the intent there was to assert something about that, or assign to it?<br>
<br>
Jon<span class="im"><br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
      std::free(p);<br>
  }<br>
<br>
<br>
Modified: libcxx/trunk/test/std/<u></u>language.support/support.<u></u>dynamic/new.delete/new.delete.<u></u>single/sized_delete.pass.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/sized_delete.pass.cpp?rev=233816&r1=233815&r2=233816&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/libcxx/trunk/test/std/<u></u>language.support/support.<u></u>dynamic/new.delete/new.delete.<u></u>single/sized_delete.pass.cpp?<u></u>rev=233816&r1=233815&r2=<u></u>233816&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- libcxx/trunk/test/std/<u></u>language.support/support.<u></u>dynamic/new.delete/new.delete.<u></u>single/sized_delete.pass.cpp (original)<br>
+++ libcxx/trunk/test/std/<u></u>language.support/support.<u></u>dynamic/new.delete/new.delete.<u></u>single/sized_delete.pass.cpp Wed Apr  1 10:49:02 2015<br>
@@ -23,7 +23,6 @@ int delete_nothrow_called = 0;<br>
  void operator delete(void* p) throw()<br>
  {<br>
      ++delete_called;<br>
-    delete_nothrow_called;<br>
      std::free(p);<br>
  }<br><br></blockquote></span></blockquote><div><br></div><div>I suspect the line you deleted was supposed to be</div><div> </div></div>  ++<span style="color:rgb(80,0,80)"> </span><span style="color:rgb(80,0,80)">delete_nothrow_called;</span></div><div class="gmail_extra"><span style="color:rgb(80,0,80)"><br></span></div><div class="gmail_extra"><font color="#500050">-- Marshall</font></div><div class="gmail_extra"><font color="#500050"><br></font></div></div>