I don't see why - architecture support should be orthogonal to the core itself. I think if you have tests that can't pass with an a57+v8.1a, it smells like dodgy tests IMHO. <br><div class="gmail_quote">On Tue, 31 Mar 2015 at 16:50, Vladimir Sukharev <<a href="mailto:vladimir.sukharev@arm.com">vladimir.sukharev@arm.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">It has been added already in backend - <a href="http://reviews.llvm.org/D8505" target="_blank">http://reviews.llvm.org/D8505</a> , where we got no other decent possibility.<br>
Why not to use the same in frontend?<br>
Also, see comments below<br>
<br>
<br>
================<br>
Comment at: lib/Basic/Targets.cpp:4197<br>
@@ -4184,2 +4196,3 @@<br>
         .Cases("cortex-a53", "cortex-a57", "cortex-a72", "8A")<br>
+        .Case("generic-armv8.1-a","8_<u></u>1A")<br>
         .Default(nullptr);<br>
----------------<br>
for a57+v8.1a it would be weird to try to pass the test, commented below.<br>
a57 would normally normally yield macro<br>
```<br>
__ARM_ARCH_8A__ 1<br>
```<br>
see <a href="https://github.com/llvm-mirror/clang/blob/1d941335617c6199e8340084c8a6c37c1b8014ec/lib/Basic/Targets.cpp#L4244" target="_blank">https://github.com/llvm-<u></u>mirror/clang/blob/<u></u>1d941335617c6199e8340084c8a6c3<u></u>7c1b8014ec/lib/Basic/Targets.<u></u>cpp#L4244</a><br>
<br>
But I suspect we'd need to have<br>
```<br>
__ARM_ARCH_8_1A__ 1<br>
```<br>
, as tested in very last test here.<br>
Unfortunately, without ACLE issued we could not yet realize, whether we'd need both of them.<br>
<br>
================<br>
Comment at: test/Preprocessor/arm-target-<u></u>features.c:322<br>
@@ +321,3 @@<br>
+// CHECK-V81A: __ARM_ARCH 8<br>
+// CHECK-V81A: __ARM_ARCH_8_1A__ 1<br>
+// CHECK-V81A: #define __ARM_ARCH_PROFILE 'A'<br>
----------------<br>
for a57+v8.1a it would be weird to pass this test<br>
<br>
<a href="http://reviews.llvm.org/D8493" target="_blank">http://reviews.llvm.org/D8493</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/<u></u>settings/panel/<u></u>emailpreferences/</a><br>
<br>
<br>
<br>
______________________________<u></u>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/cfe-commits</a><br>
</blockquote></div>