<div dir="ltr">I don't feel strongly about this, and I can see some of your reasoning. However, an "if (a) return true; else return false;" is very suspect to me and I think "return a;" is more readable, independent of whether it is at the end of a chain or not.<div><br></div><div>However, there is an underlying issue here. The existing code is violating LLVM's coding standard of "don't use else after return" (<a href="http://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return">http://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return</a>). So in these chains, all of the "else"s should be removed.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 24, 2015 at 7:17 AM, Richard <span dir="ltr"><<a href="mailto:legalize@xmission.com" target="_blank">legalize@xmission.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thanks for your ideas, John, I'm going to incorporate this into the `clang-tidy` check.<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
<a href="http://reviews.llvm.org/D8532" target="_blank">http://reviews.llvm.org/D8532</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div>