<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 23, 2015 at 10:37 PM, Ben Langmuir <span dir="ltr"><<a href="mailto:blangmuir@apple.com" target="_blank">blangmuir@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><blockquote type="cite"><div>On Mar 23, 2015, at 10:21 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>> wrote:</div><br><div><br><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">On Mon, Mar 23, 2015 at 9:54 PM, Ben Langmuir<span> </span></span><span dir="ltr" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><<a href="mailto:blangmuir@apple.com" target="_blank">blangmuir@apple.com</a>></span><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important"> </span><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">wrote:</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><blockquote class="gmail_quote" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span><blockquote type="cite"><div>On Mar 23, 2015, at 5:38 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>> wrote:</div><br><div><div dir="ltr">Digging this thread back up, I'm starting to work on <span class="il">deterministic</span> output of <span class="il">modules</span>. This is *really* important. Unfortunately, it's almost impossible to make progress as long as this code is actually firing because it kind of makes things definitively non-<span class="il">deterministic</span>. ;]</div></div></blockquote><blockquote type="cite"><div><div dir="ltr"><div><br></div><div>Ben, do you have any concerns about only emitting the signature record for implicit <span class="il">modules</span>? This would omit it for explicit <span class="il">modules</span> (where I'm working), PCH files, etc. Based on your commit message and explanation, it doesn't really make sense outside of implicit <span class="il">modules</span> AFAICT, and we're hoping it will go away completely.</div></div></div></blockquote><div><br></div></span><div>SGTM although I would prefer we continue to check the /expected/ signature when an AST file imports an implicit <span class="il">module</span> (and in particular when a PCH imports an implicit <span class="il">module</span>).  Thanks for working on this!</div></blockquote><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"> </div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">I'm not planning to change the checking code path at all. All the tests pass if I just restrict the emission to be when generating implicit <span class="il">modules</span></div></div></blockquote><div><br></div></span><div>Perfect, that’s what I was hoping for.  Sorry I didn’t phrase it clearly.</div></blockquote></div><br>This is in as part of r233115 with the minimal test case for deterministic output. More to come.</div></div>