<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Mar 23, 2015 at 12:39 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dblaikie<br>
Date: Mon Mar 23 14:39:19 2015<br>
New Revision: 232999<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=232999&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=232999&view=rev</a><br>
Log:<br>
Refactor: Simplify boolean expresssions in lib/Lex<br>
<br>
Simplify boolean expressions using `true` and `false` with `clang-tidy`<br>
<br>
Patch by Richard Thomson.<br>
<br>
Differential Revision: <a href="http://reviews.llvm.org/D8531" target="_blank">http://reviews.llvm.org/D8531</a><br>
<br>
Modified:<br>
    cfe/trunk/lib/Lex/LiteralSupport.cpp<br>
<br>
Modified: cfe/trunk/lib/Lex/LiteralSupport.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Lex/LiteralSupport.cpp?rev=232999&r1=232998&r2=232999&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Lex/LiteralSupport.cpp?rev=232999&r1=232998&r2=232999&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Lex/LiteralSupport.cpp (original)<br>
+++ cfe/trunk/lib/Lex/LiteralSupport.cpp Mon Mar 23 14:39:19 2015<br>
@@ -144,7 +144,7 @@ static unsigned ProcessCharEscape(const<br>
       int CharVal = llvm::hexDigitValue(ThisTokBuf[0]);<br>
       if (CharVal == -1) break;<br>
       // About to shift out a digit?<br>
-      Overflow |= (ResultChar & 0xF0000000) ? true : false;<br>
+      Overflow |= ResultChar & 0xF0000000;<br></blockquote><div><br></div><div>Is this actually simpler? This line now reads like it's conditionally setting bits 28-31 of Overflow, whereas previously it was clear that Overflow is a bool without needing any additional context. I think</div><div><br></div><div>  if (ResultChar & 0xF0000000) Overflow = true;</div><div><br></div><div>is better than either the old or new code.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
       ResultChar <<= 4;<br>
       ResultChar |= CharVal;<br>
     }<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>