<div dir="ltr">Looks good - committed in r232999</div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Mar 22, 2015 at 1:38 PM, Richard <span dir="ltr"><<a href="mailto:legalize@xmission.com" target="_blank">legalize@xmission.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi alexfh, doug.gregor, akyrtzi, krememek, rsmith,<br>
<br>
Simplify boolean expressions using `true` and `false` with `clang-tidy`<br>
<br>
<a href="http://reviews.llvm.org/D8531" target="_blank">http://reviews.llvm.org/D8531</a><br>
<br>
Files:<br>
  lib/Lex/LiteralSupport.cpp<br>
<br>
Index: lib/Lex/LiteralSupport.cpp<br>
===================================================================<br>
--- lib/Lex/LiteralSupport.cpp<br>
+++ lib/Lex/LiteralSupport.cpp<br>
@@ -144,7 +144,7 @@<br>
       int CharVal = llvm::hexDigitValue(ThisTokBuf[0]);<br>
       if (CharVal == -1) break;<br>
       // About to shift out a digit?<br>
-      Overflow |= (ResultChar & 0xF0000000) ? true : false;<br>
+      Overflow |= (ResultChar & 0xF0000000);<br>
       ResultChar <<= 4;<br>
       ResultChar |= CharVal;<br>
     }<br>
<br>
EMAIL PREFERENCES<br>
  <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>