<div dir="ltr">LGTM, please commit.</div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Mar 14, 2015 at 11:11 AM, Szabolcs Sipos <span dir="ltr"><<a href="mailto:szabolcs.sipos@ericsson.com" target="_blank">szabolcs.sipos@ericsson.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi alexfh,<br>
<br>
This patch consists of the suggestions of clang-tidy/misc-static-assert check.<br>
<br>
<a href="http://reviews.llvm.org/D8344" target="_blank">http://reviews.llvm.org/D8344</a><br>
<br>
Files:<br>
lib/Sema/SemaChecking.cpp<br>
<br>
Index: lib/Sema/SemaChecking.cpp<br>
===================================================================<br>
--- lib/Sema/SemaChecking.cpp<br>
+++ lib/Sema/SemaChecking.cpp<br>
@@ -1305,9 +1305,10 @@<br>
// M is C if C is an integer, and ptrdiff_t if C is a pointer, and<br>
// the int parameters are for orderings.<br>
<br>
- assert(AtomicExpr::AO__c11_atomic_init == 0 &&<br>
- AtomicExpr::AO__c11_atomic_fetch_xor + 1 == AtomicExpr::AO__atomic_load<br>
- && "need to update code for modified C11 atomics");<br>
+ static_assert(AtomicExpr::AO__c11_atomic_init == 0 &&<br>
+ AtomicExpr::AO__c11_atomic_fetch_xor + 1 ==<br>
+ AtomicExpr::AO__atomic_load,<br>
+ "need to update code for modified C11 atomics");<br>
bool IsC11 = Op >= AtomicExpr::AO__c11_atomic_init &&<br>
Op <= AtomicExpr::AO__c11_atomic_fetch_xor;<br>
bool IsN = Op == AtomicExpr::AO__atomic_load_n ||<br>
<br>
EMAIL PREFERENCES<br>
<a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>