<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">ping... I really want to close that
annoying bugzilla ticket ;)<br>
On 18/09/14 20:08, Vassil Vassilev wrote:<br>
</div>
<blockquote cite="mid:541B1F90.20506@cern.ch" type="cite">On
18/09/14 18:04, Ben Langmuir wrote:
<br>
<blockquote type="cite">
<blockquote type="cite">On Sep 18, 2014, at 3:47 AM, Vassil
Vassilev <a class="moz-txt-link-rfc2396E" href="mailto:vasil.georgiev.vasilev@cern.ch"><vasil.georgiev.vasilev@cern.ch></a> wrote:
<br>
<br>
On 09/17/2014 09:51 PM, Ben Langmuir wrote:
<br>
<blockquote type="cite">
<blockquote type="cite">Index: docs/LanguageExtensions.rst
<br>
===================================================================
<br>
--- docs/LanguageExtensions.rst (revision 217389)
<br>
+++ docs/LanguageExtensions.rst (working copy)
<br>
@@ -477,6 +477,13 @@
<br>
Use ``__has_feature(cxx_rtti)`` to determine if C++ RTTI
has been enabled. For
<br>
example, compiling code with ``-fno-rtti`` disables the
use of RTTI.
<br>
+C++ Modules
<br>
+^^^^^^^^
<br>
+
<br>
+Use ``__has_feature(modules)`` to determine if
experimental C++ Modules have
<br>
+been enabled. For example, compiling code with
``-fmodules`` enables the use of
<br>
+C++ Modules.
<br>
+
<br>
C++11
<br>
-----
<br>
<br>
</blockquote>
Why are we making this specific to C++ modules? Modules are
supported in C/ObjC. And to actually get modules in C++ you
also need -fcxx-modules.
<br>
</blockquote>
Thanks for the comments. lib/Driver/Tools.cpp:3790 says:
<br>
// -fmodules enables modules (off by default). However, for
C++/Objective-C++,
<br>
// users must also pass -fcxx-modules. The latter flag will
disappear once the
<br>
// modules implementation is solid for C++/Objective-C++
programs as well.
<br>
<br>
I prefer not to document the -fcxx-modules.
<br>
</blockquote>
Yep, makes sense.
<br>
<br>
<blockquote type="cite">The attached patch doesn't mention the
C++ modules but Modules in general (I decided to put them into
a separate section). Is it any better?
<br>
Vassil
<br>
</blockquote>
Much better - a couple more comments below:
<br>
<br>
<blockquote type="cite">+Modules
<br>
+-------
<br>
+
<br>
+C/ObjC Modules
<br>
+^^^^^^^^^^^^^^
<br>
</blockquote>
Do we really need a sub-heading? If we do need one I suggest “C
and Objective-C Modules”. Otherwise just a heading “Modules”
seems sufficient.
<br>
</blockquote>
Yep good point.
<br>
<blockquote type="cite">
<br>
<blockquote type="cite">+
<br>
+Use ``__has_feature(modules)`` to determine if Modules have
been enabled.
<br>
+For example, compiling code with ``-fmodules`` enables the
use of Modules.
<br>
</blockquote>
I suggest we put in a link to the modules documentation.
<br>
</blockquote>
Now should be better. Thanks!
<br>
Vassil
<br>
<blockquote type="cite">
<br>
<blockquote type="cite">
<blockquote type="cite">Ben
<br>
<br>
<blockquote type="cite">On Sep 17, 2014, at 12:59 AM, Vassil
Vassilev <a class="moz-txt-link-rfc2396E" href="mailto:vasil.georgiev.vasilev@cern.ch"><vasil.georgiev.vasilev@cern.ch></a> wrote:
<br>
<br>
Hi,
<br>
I am attaching a patch addressing
<a class="moz-txt-link-freetext" href="http://llvm.org/bugs/show_bug.cgi?id=18985">http://llvm.org/bugs/show_bug.cgi?id=18985</a>
<br>
I wasn't sure whether I had to say 'experimental C++
modules'.
<br>
Vassil
<br>
<Bug18985.diff>_______________________________________________
<br>
cfe-commits mailing list
<br>
<a class="moz-txt-link-abbreviated" href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a>
<br>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a>
<br>
</blockquote>
</blockquote>
<Bug18985_1.diff>
<br>
</blockquote>
</blockquote>
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
cfe-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a>
</pre>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
--------------------------------------------
Q: Why is this email five sentences or less?
A: <a class="moz-txt-link-freetext" href="http://five.sentenc.es">http://five.sentenc.es</a>
</pre>
</body>
</html>