<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Ack, your response somehow got lost.<div class=""><br class=""></div><div class="">LGTM.</div><div class=""><br class=""></div><div class=""><blockquote type="cite" class="">+More information could be found `here <<a href="http://clang.llvm.org/docs/Modules.html" class="">http://clang.llvm.org/docs/Modules.html</a>>`_</blockquote><br class=""></div><div class="">This should probably end with a period.</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Mar 10, 2015, at 1:10 AM, Vassil Vassilev <<a href="mailto:vvasilev@cern.ch" class="">vvasilev@cern.ch</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
<meta content="text/html; charset=windows-1252" http-equiv="Content-Type" class="">
<div text="#000000" bgcolor="#FFFFFF" class="">
<div class="moz-cite-prefix">ping... I really want to close that
annoying bugzilla ticket ;)<br class="">
On 18/09/14 20:08, Vassil Vassilev wrote:<br class="">
</div>
<blockquote cite="mid:541B1F90.20506@cern.ch" type="cite" class="">On
18/09/14 18:04, Ben Langmuir wrote:
<br class="">
<blockquote type="cite" class="">
<blockquote type="cite" class="">On Sep 18, 2014, at 3:47 AM, Vassil
Vassilev <a class="moz-txt-link-rfc2396E" href="mailto:vasil.georgiev.vasilev@cern.ch"><vasil.georgiev.vasilev@cern.ch></a> wrote:
<br class="">
<br class="">
On 09/17/2014 09:51 PM, Ben Langmuir wrote:
<br class="">
<blockquote type="cite" class="">
<blockquote type="cite" class="">Index: docs/LanguageExtensions.rst
<br class="">
===================================================================
<br class="">
--- docs/LanguageExtensions.rst (revision 217389)
<br class="">
+++ docs/LanguageExtensions.rst (working copy)
<br class="">
@@ -477,6 +477,13 @@
<br class="">
Use ``__has_feature(cxx_rtti)`` to determine if C++ RTTI
has been enabled. For
<br class="">
example, compiling code with ``-fno-rtti`` disables the
use of RTTI.
<br class="">
+C++ Modules
<br class="">
+^^^^^^^^
<br class="">
+
<br class="">
+Use ``__has_feature(modules)`` to determine if
experimental C++ Modules have
<br class="">
+been enabled. For example, compiling code with
``-fmodules`` enables the use of
<br class="">
+C++ Modules.
<br class="">
+
<br class="">
C++11
<br class="">
-----
<br class="">
<br class="">
</blockquote>
Why are we making this specific to C++ modules? Modules are
supported in C/ObjC. And to actually get modules in C++ you
also need -fcxx-modules.
<br class="">
</blockquote>
Thanks for the comments. lib/Driver/Tools.cpp:3790 says:
<br class="">
// -fmodules enables modules (off by default). However, for
C++/Objective-C++,
<br class="">
// users must also pass -fcxx-modules. The latter flag will
disappear once the
<br class="">
// modules implementation is solid for C++/Objective-C++
programs as well.
<br class="">
<br class="">
I prefer not to document the -fcxx-modules.
<br class="">
</blockquote>
Yep, makes sense.
<br class="">
<br class="">
<blockquote type="cite" class="">The attached patch doesn't mention the
C++ modules but Modules in general (I decided to put them into
a separate section). Is it any better?
<br class="">
Vassil
<br class="">
</blockquote>
Much better - a couple more comments below:
<br class="">
<br class="">
<blockquote type="cite" class="">+Modules
<br class="">
+-------
<br class="">
+
<br class="">
+C/ObjC Modules
<br class="">
+^^^^^^^^^^^^^^
<br class="">
</blockquote>
Do we really need a sub-heading? If we do need one I suggest “C
and Objective-C Modules”. Otherwise just a heading “Modules”
seems sufficient.
<br class="">
</blockquote>
Yep good point.
<br class="">
<blockquote type="cite" class="">
<br class="">
<blockquote type="cite" class="">+
<br class="">
+Use ``__has_feature(modules)`` to determine if Modules have
been enabled.
<br class="">
+For example, compiling code with ``-fmodules`` enables the
use of Modules.
<br class="">
</blockquote>
I suggest we put in a link to the modules documentation.
<br class="">
</blockquote>
Now should be better. Thanks!
<br class="">
Vassil
<br class="">
<blockquote type="cite" class="">
<br class="">
<blockquote type="cite" class="">
<blockquote type="cite" class="">Ben
<br class="">
<br class="">
<blockquote type="cite" class="">On Sep 17, 2014, at 12:59 AM, Vassil
Vassilev <a class="moz-txt-link-rfc2396E" href="mailto:vasil.georgiev.vasilev@cern.ch"><vasil.georgiev.vasilev@cern.ch></a> wrote:
<br class="">
<br class="">
Hi,
<br class="">
I am attaching a patch addressing
<a class="moz-txt-link-freetext" href="http://llvm.org/bugs/show_bug.cgi?id=18985">http://llvm.org/bugs/show_bug.cgi?id=18985</a>
<br class="">
I wasn't sure whether I had to say 'experimental C++
modules'.
<br class="">
Vassil
<br class="">
<Bug18985.diff>_______________________________________________
<br class="">
cfe-commits mailing list
<br class="">
<a class="moz-txt-link-abbreviated" href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a>
<br class="">
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a>
<br class="">
</blockquote>
</blockquote>
<Bug18985_1.diff>
<br class="">
</blockquote>
</blockquote>
<br class="">
<br class="">
<br class="">
<fieldset class="mimeAttachmentHeader"></fieldset>
<br class="">
<pre wrap="" class="">_______________________________________________
cfe-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a>
</pre>
</blockquote>
<br class="">
<br class="">
<pre class="moz-signature" cols="72">--
--------------------------------------------
Q: Why is this email five sentences or less?
A: <a class="moz-txt-link-freetext" href="http://five.sentenc.es/">http://five.sentenc.es</a>
</pre>
</div>
</div></blockquote></div><br class=""></div></body></html>