<p dir="ltr"><br>
On Mar 9, 2015 8:11 AM, "Benjamin Kramer" <<a href="mailto:benny.kra@googlemail.com">benny.kra@googlemail.com</a>> wrote:<br>
><br>
> Author: d0k<br>
> Date: Mon Mar  9 10:03:32 2015<br>
> New Revision: 231657<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=231657&view=rev">http://llvm.org/viewvc/llvm-project?rev=231657&view=rev</a><br>
> Log:<br>
> Make helper functions static</p>
<p dir="ltr">Are you finding these with -Wprototype or some other tool? I'd be curious to see if we could turn on -Wprototype.</p>
<p dir="ltr">><br>
> NFC.<br>
><br>
> Modified:<br>
>     cfe/trunk/lib/Analysis/Consumed.cpp<br>
>     cfe/trunk/lib/Sema/SemaChecking.cpp<br>
><br>
> Modified: cfe/trunk/lib/Analysis/Consumed.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/Consumed.cpp?rev=231657&r1=231656&r2=231657&view=diff">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/Consumed.cpp?rev=231657&r1=231656&r2=231657&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/lib/Analysis/Consumed.cpp (original)<br>
> +++ cfe/trunk/lib/Analysis/Consumed.cpp Mon Mar  9 10:03:32 2015<br>
> @@ -946,10 +946,9 @@ void ConsumedStmtVisitor::VisitVarDecl(c<br>
>  namespace clang {<br>
>  namespace consumed {<br>
><br>
> -void splitVarStateForIf(const IfStmt * IfNode, const VarTestResult &Test,<br>
> -                        ConsumedStateMap *ThenStates,<br>
> -                        ConsumedStateMap *ElseStates) {<br>
> -<br>
> +static void splitVarStateForIf(const IfStmt *IfNode, const VarTestResult &Test,<br>
> +                               ConsumedStateMap *ThenStates,<br>
> +                               ConsumedStateMap *ElseStates) {<br>
>    ConsumedState VarState = ThenStates->getState(Test.Var);<br>
><br>
>    if (VarState == CS_Unknown) {<br>
> @@ -964,9 +963,9 @@ void splitVarStateForIf(const IfStmt * I<br>
>    }<br>
>  }<br>
><br>
> -void splitVarStateForIfBinOp(const PropagationInfo &PInfo,<br>
> -  ConsumedStateMap *ThenStates, ConsumedStateMap *ElseStates) {<br>
> -<br>
> +static void splitVarStateForIfBinOp(const PropagationInfo &PInfo,<br>
> +                                    ConsumedStateMap *ThenStates,<br>
> +                                    ConsumedStateMap *ElseStates) {<br>
>    const VarTestResult &LTest = PInfo.getLTest(),<br>
>                        &RTest = PInfo.getRTest();<br>
><br>
><br>
> Modified: cfe/trunk/lib/Sema/SemaChecking.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaChecking.cpp?rev=231657&r1=231656&r2=231657&view=diff">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaChecking.cpp?rev=231657&r1=231656&r2=231657&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/lib/Sema/SemaChecking.cpp (original)<br>
> +++ cfe/trunk/lib/Sema/SemaChecking.cpp Mon Mar  9 10:03:32 2015<br>
> @@ -8187,8 +8187,8 @@ static bool isSetterLikeSelector(Selecto<br>
>    return !isLowercase(str.front());<br>
>  }<br>
><br>
> -Optional<int> GetNSMutableArrayArgumentIndex(Sema &S, ObjCMessageExpr *Message) {<br>
> -<br>
> +static Optional<int> GetNSMutableArrayArgumentIndex(Sema &S,<br>
> +                                                    ObjCMessageExpr *Message) {<br>
>    if (S.NSMutableArrayPointer.isNull()) {<br>
>      IdentifierInfo *NSMutableArrayId =<br>
>        S.NSAPIObj->getNSClassId(NSAPI::ClassId_NSMutableArray);<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</p>