<div dir="ltr">This is breaking buildbots: <a href="http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/4668/">http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/4668/</a><div><br></div><div>Reverted in r231248.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 4, 2015 at 3:24 PM, Toma Tabacu <span dir="ltr"><<a href="mailto:toma.tabacu@imgtec.com" target="_blank">toma.tabacu@imgtec.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: tomatabacu<br>
Date: Wed Mar  4 08:24:25 2015<br>
New Revision: 231244<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=231244&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=231244&view=rev</a><br>
Log:<br>
[IAS] Teach -cc1as about the 'target-abi' option.<br>
<br>
Summary:<br>
When using the IAS from clang, the 'target-abi' option gets passed to cc1as, but cc1as doesn't know about it and gives an "unknown argument" error.<br>
<br>
This is fixed by adding the 'CC1AsOption' flag to the 'target-abi' option in CC1Options.td.<br>
<br>
Reviewers: atanasyan, echristo, dsanders<br>
<br>
Reviewed By: dsanders<br>
<br>
Subscribers: cfe-commits<br>
<br>
Differential Revision: <a href="http://reviews.llvm.org/D7903" target="_blank">http://reviews.llvm.org/D7903</a><br>
<br>
Added:<br>
    cfe/trunk/test/Driver/target-abi-cc1as.s<br>
Modified:<br>
    cfe/trunk/include/clang/Driver/CC1Options.td<br>
<br>
Modified: cfe/trunk/include/clang/Driver/CC1Options.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/CC1Options.td?rev=231244&r1=231243&r2=231244&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/CC1Options.td?rev=231244&r1=231243&r2=231244&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/include/clang/Driver/CC1Options.td (original)<br>
+++ cfe/trunk/include/clang/Driver/CC1Options.td Wed Mar  4 08:24:25 2015<br>
@@ -25,11 +25,11 @@ def target_feature : Separate<["-"], "ta<br>
   HelpText<"Target specific attributes">;<br>
 def triple : Separate<["-"], "triple">,<br>
   HelpText<"Specify target triple (e.g. i686-apple-darwin9)">;<br>
+def target_abi : Separate<["-"], "target-abi">,<br>
+  HelpText<"Target a particular ABI type">;<br>
<br>
 }<br>
<br>
-def target_abi : Separate<["-"], "target-abi">,<br>
-  HelpText<"Target a particular ABI type">;<br>
 def target_linker_version : Separate<["-"], "target-linker-version">,<br>
   HelpText<"Target linker version">;<br>
 def triple_EQ : Joined<["-"], "triple=">, Alias<triple>;<br>
<br>
Added: cfe/trunk/test/Driver/target-abi-cc1as.s<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/target-abi-cc1as.s?rev=231244&view=auto" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/target-abi-cc1as.s?rev=231244&view=auto</a><br>
==============================================================================<br>
--- cfe/trunk/test/Driver/target-abi-cc1as.s (added)<br>
+++ cfe/trunk/test/Driver/target-abi-cc1as.s Wed Mar  4 08:24:25 2015<br>
@@ -0,0 +1,5 @@<br>
+// Check if -cc1as knows about the 'target-abi' argument.<br>
+<br>
+// RUN: %clang -cc1as -triple mips--linux-gnu -filetype obj -target-cpu mips32 -target-abi o32 %s 2>&1 | \<br>
+// RUN:   FileCheck --check-prefix=ABI-O32 %s<br>
+// ABI-O32-NOT: clang -cc1as: error: unknown argument: '-target-abi'<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>