<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-GB" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Hi,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Sorry. I was going to revert it, but you beat me to it.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Toma Tabacu<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Daniel Jasper [mailto:djasper@google.com]
<br>
<b>Sent:</b> 04 March 2015 15:05<br>
<b>To:</b> Toma Tabacu<br>
<b>Cc:</b> Clang Commits<br>
<b>Subject:</b> Re: r231244 - [IAS] Teach -cc1as about the 'target-abi' option.<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">This is breaking buildbots: <a href="http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/4668/">http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/4668/</a><o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Reverted in r231248.<o:p></o:p></p>
</div>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On Wed, Mar 4, 2015 at 3:24 PM, Toma Tabacu <<a href="mailto:toma.tabacu@imgtec.com" target="_blank">toma.tabacu@imgtec.com</a>> wrote:<o:p></o:p></p>
<p class="MsoNormal">Author: tomatabacu<br>
Date: Wed Mar 4 08:24:25 2015<br>
New Revision: 231244<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=231244&view=rev" target="_blank">
http://llvm.org/viewvc/llvm-project?rev=231244&view=rev</a><br>
Log:<br>
[IAS] Teach -cc1as about the 'target-abi' option.<br>
<br>
Summary:<br>
When using the IAS from clang, the 'target-abi' option gets passed to cc1as, but cc1as doesn't know about it and gives an "unknown argument" error.<br>
<br>
This is fixed by adding the 'CC1AsOption' flag to the 'target-abi' option in CC1Options.td.<br>
<br>
Reviewers: atanasyan, echristo, dsanders<br>
<br>
Reviewed By: dsanders<br>
<br>
Subscribers: cfe-commits<br>
<br>
Differential Revision: <a href="http://reviews.llvm.org/D7903" target="_blank">http://reviews.llvm.org/D7903</a><br>
<br>
Added:<br>
cfe/trunk/test/Driver/target-abi-cc1as.s<br>
Modified:<br>
cfe/trunk/include/clang/Driver/CC1Options.td<br>
<br>
Modified: cfe/trunk/include/clang/Driver/CC1Options.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/CC1Options.td?rev=231244&r1=231243&r2=231244&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/CC1Options.td?rev=231244&r1=231243&r2=231244&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/include/clang/Driver/CC1Options.td (original)<br>
+++ cfe/trunk/include/clang/Driver/CC1Options.td Wed Mar 4 08:24:25 2015<br>
@@ -25,11 +25,11 @@ def target_feature : Separate<["-"], "ta<br>
HelpText<"Target specific attributes">;<br>
def triple : Separate<["-"], "triple">,<br>
HelpText<"Specify target triple (e.g. i686-apple-darwin9)">;<br>
+def target_abi : Separate<["-"], "target-abi">,<br>
+ HelpText<"Target a particular ABI type">;<br>
<br>
}<br>
<br>
-def target_abi : Separate<["-"], "target-abi">,<br>
- HelpText<"Target a particular ABI type">;<br>
def target_linker_version : Separate<["-"], "target-linker-version">,<br>
HelpText<"Target linker version">;<br>
def triple_EQ : Joined<["-"], "triple=">, Alias<triple>;<br>
<br>
Added: cfe/trunk/test/Driver/target-abi-cc1as.s<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/target-abi-cc1as.s?rev=231244&view=auto" target="_blank">
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/target-abi-cc1as.s?rev=231244&view=auto</a><br>
==============================================================================<br>
--- cfe/trunk/test/Driver/target-abi-cc1as.s (added)<br>
+++ cfe/trunk/test/Driver/target-abi-cc1as.s Wed Mar 4 08:24:25 2015<br>
@@ -0,0 +1,5 @@<br>
+// Check if -cc1as knows about the 'target-abi' argument.<br>
+<br>
+// RUN: %clang -cc1as -triple mips--linux-gnu -filetype obj -target-cpu mips32 -target-abi o32 %s 2>&1 | \<br>
+// RUN: FileCheck --check-prefix=ABI-O32 %s<br>
+// ABI-O32-NOT: clang -cc1as: error: unknown argument: '-target-abi'<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</body>
</html>