<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Mar 3, 2015, at 11:02 AM, jahanian <<a href="mailto:fjahanian@apple.com">fjahanian@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=us-ascii"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Patch looks good with couple of minors.<div>Provide a note where receiver/argument has been declared.</div><div>Place CheckObjCCircularContainer(Result) right after <span style="color: rgb(49, 89, 93); font-family: Menlo; font-size: 11px;">checkRetainCycles</span><span style="font-family: Menlo; font-size: 11px;">(Result).</span></div></div></blockquote><div><br></div>This patch does not address the general case of same expression used as receiver and addObject argument.<div>Is this something that you care enough to address? Need not be in this patch though.</div><div><br></div><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div><span style="font-family: Menlo; font-size: 11px;"><br></span></div><div><span style="font-family: Menlo; font-size: 11px;">- Fariborz</span></div><div><span style="font-family: Menlo; font-size: 11px;"><br></span></div><div><br></div></div></blockquote></div><br></body></html>